[Pkg-mozext-commits] [compactheader] 269/441: Branch for review requests: You have added DOM modification event listeners in the main window (example: mailToolbox.addEventListener("DOMAttrModified" ...). Adding these listeners anywhere causes a significant slowdown of the entire application. Although this is not strictly forbidden, it is strongly discouraged, and you would need to vigorously defend why this is necessary in the comments to the editors. I strongly encourage you to find some other method to accomplish your goals.

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository compactheader.

commit 42c621c9af96a35aea831052e3249840689b3ce8
Author: Joachim.Herb at gmx.de <Joachim.Herb at gmx.de>
Date:   Tue Aug 23 22:28:40 2011 +0200

    Branch for review requests:
    You have added DOM modification event listeners in the main window (example:
    mailToolbox.addEventListener("DOMAttrModified" ...). Adding these listeners
    anywhere causes a significant slowdown of the entire application.  Although this
    is not strictly forbidden, it is strongly discouraged, and you would need to
    vigorously defend why this is necessary in the comments to the editors. I
    strongly encourage you to find some other method to accomplish your goals.
    
    While not necessary for this current update to be approved, there a number of
    other issues that need to be fixed in a future version of your addon:
    
    1) You have made no attempt to namespace the DOM ids that you add. We now
    require that DOM ids being added to public pages have a prefix that is unique to
    your addon.
    
    2) There are a few non-namespaced  javascript variables that are leaking into
    the main windows: EXPORTED_SYMBOLS, removeButtonDispMUA, url
    
    --HG--
    branch : review_requests

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/compactheader.git