[Pkg-mozext-commits] [requestpolicy] 146/280: fix "TypeError: can't access dead object"

David Prévot taffit at moszumanska.debian.org
Sat May 2 20:30:14 UTC 2015


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository requestpolicy.

commit ed773bfe803716b677d9843125e47fac724fc28c
Author: Martin Kimmerle <dev at 256k.de>
Date:   Sat Jan 17 17:27:08 2015 +0100

    fix "TypeError: can't access dead object"
    
    The TypeError came up when accessing `doc` in `cleanUpDoc()`
    when closing a tab. On the document's "unload" event, the
    function `cleanUpThisDoc()` did not call `cleanUpDoc(docID)`
    correctly because `docID` did not exist anymore.
---
 src/content/ui/frame.doc-manager.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/content/ui/frame.doc-manager.js b/src/content/ui/frame.doc-manager.js
index acf0afc..e2c76f4 100644
--- a/src/content/ui/frame.doc-manager.js
+++ b/src/content/ui/frame.doc-manager.js
@@ -57,9 +57,7 @@ let DocManager = (function() {
 
     let docID = nextDocID++;
 
-    function cleanUpThisDoc() {
-      cleanUpDoc(docID);
-    };
+    let cleanUpThisDoc = cleanUpDoc.bind(this, docID);
 
     // Destructor function:
     // As soon as the document is unloaded, delete the reference.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/requestpolicy.git



More information about the Pkg-mozext-commits mailing list