[Pkg-mozext-commits] [requestpolicy] 03/12: revert commit 73eabfd

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository requestpolicy.

commit c71349191d703877f473d97593109525c55485b6
Author: Martin Kimmerle <dev at 256k.de>
Date:   Fri May 22 03:18:37 2015 +0200

    revert commit 73eabfd
    
    jQuery's `hide()` and `show()` functions are not equivalent to
    setting an element's `hidden` argument to `false` or `true`!
---
 src/content/settings/oldrules.js   | 26 +++++++++++++-------------
 src/content/settings/yourpolicy.js |  2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/content/settings/oldrules.js b/src/content/settings/oldrules.js
index 4eadd11..1f2c1d0 100644
--- a/src/content/settings/oldrules.js
+++ b/src/content/settings/oldrules.js
@@ -69,16 +69,16 @@ function deleteOldRules() {
   common.clearPref('allowedOrigins');
   common.clearPref('allowedDestinations');
   common.clearPref('allowedOriginsToDestinations');
-  $id("doimport").hidden = true;
-  $id("deletedone").hidden = false;
-  $id("showReimportOptions").hidden = true;
-  $id("reimportOldRules").hidden = true;
-  $id("deleteOldRules").hidden = true;
+  $("#doimport").hide();
+  $("#deletedone").show();
+  $("#showReimportOptions").hide();
+  $("#reimportOldRules").hide();
+  $("#deleteOldRules").hide();
 }
 
 function showReimportOptions() {
-  $id("showReimportOptions").hidden = true;
-  $id("reimportOldRules").hidden = false;
+  $("#showReimportOptions").hide();
+  $("#reimportOldRules").show();
 }
 
 function importOldRules() {
@@ -86,10 +86,10 @@ function importOldRules() {
     throw 'rules is undefined or empty';
   }
   common.addAllowRules(rules);
-  $id("doimport").hidden = true;
-  $id("policy").hidden = true;
-  $id("importoptions").hidden = true;
-  $id("importdone").hidden = false;
+  $("#doimport").hide();
+  $("#policy").hide();
+  $("#importoptions").hide();
+  $("#importdone").show();
 }
 
 function handleAddHostWildcardsChange(event) {
@@ -101,8 +101,8 @@ function handleAddHostWildcardsChange(event) {
 function onload() {
   var oldRulesExist = Prefs.oldRulesExist();
   if (!oldRulesExist) {
-    $id("hasrules").hidden = true;
-    $id("norules").hidden = false;
+    $("#hasrules").hide();
+    $("#norules").show();
     return;
   }
   populateRuleTable();
diff --git a/src/content/settings/yourpolicy.js b/src/content/settings/yourpolicy.js
index a9e1a6a..e4416d2 100644
--- a/src/content/settings/yourpolicy.js
+++ b/src/content/settings/yourpolicy.js
@@ -232,7 +232,7 @@ function onload() {
   }, false);
   populateRuleTable(search.value);
   if (Prefs.oldRulesExist()) {
-    $id("oldrulesexist").hidden = false;
+    $("#oldrulesexist").show();
   }
 
   // observe rule changes and update the table then

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/requestpolicy.git