[Pkg-mozext-commits] [requestpolicy] 45/257: [ref] request processor: add `fixme` comments

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository requestpolicy.

commit f50c4ba3cf243ad5d317cf53055c8a39b5dd27ab
Author: Martin Kimmerle <dev at 256k.de>
Date:   Wed Sep 2 08:49:00 2015 +0200

    [ref] request processor: add `fixme` comments
---
 src/content/lib/request-processor.redirects.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/content/lib/request-processor.redirects.js b/src/content/lib/request-processor.redirects.js
index f848183..a690e0d 100644
--- a/src/content/lib/request-processor.redirects.js
+++ b/src/content/lib/request-processor.redirects.js
@@ -138,6 +138,7 @@ let RequestProcessor = (function(self) {
       return result;
     }
 
+    // fixme: "//example.com/path" is also a valid relative URL
     if (destURI[0] && destURI[0] == '/'
         || destURI.indexOf(":") == -1) {
       // Redirect is to a relative url.
@@ -424,6 +425,8 @@ let RequestProcessor = (function(self) {
     let originString = httpResponse.originURI.specIgnoringRef;
 
     // Allow redirects of requests from privileged code.
+    // Fixme: should the check instead be ' === false' in case the
+    //        return value is `null`? See also #18.
     if (!isContentRequest(httpResponse)) {
       // However, favicon requests that are redirected appear as non-content
       // requests. So, check if the original request was for a favicon.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/requestpolicy.git