[Pkg-mozext-commits] [requestpolicy] 126/257: [ref] fix misuse of the english word "eventually"

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository requestpolicy.

commit 318e6825f8208ebb0f36cd6adbb7d1e8fa5eb0f3
Author: Martin Kimmerle <dev at 256k.de>
Date:   Fri Oct 30 00:09:54 2015 +0100

    [ref] fix misuse of the english word "eventually"
---
 Makefile                                       | 2 +-
 src/content/lib/request-processor.redirects.js | 4 ++--
 src/content/lib/utils.jsm                      | 5 ++---
 src/content/main/pref-manager.jsm              | 4 ++--
 src/content/ui/frame.dom-content-loaded.js     | 4 ++--
 src/content/ui/menu.js                         | 3 +--
 src/content/ui/overlay.js                      | 2 +-
 7 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/Makefile b/Makefile
index 7200597..aea8cb8 100644
--- a/Makefile
+++ b/Makefile
@@ -365,7 +365,7 @@ $(specific_xpi__file):
 # create the files for the "off-AMO" XPI
 #
 
-# Process all source files, but also eventually delete
+# Process all source files and, if necessary, delete all
 # empty directories and deleted files from the build directory.
 $(off_amo__build_path): $(off_amo__all_files) $(off_amo__deleted_files) $(off_amo__empty_dirs)
 
diff --git a/src/content/lib/request-processor.redirects.js b/src/content/lib/request-processor.redirects.js
index 1bfd01b..55d3d04 100644
--- a/src/content/lib/request-processor.redirects.js
+++ b/src/content/lib/request-processor.redirects.js
@@ -243,7 +243,7 @@ RequestProcessor = (function(self) {
           browser.rpcontinued.blockedRedirects[originURI] = destURI;
         }
 
-        eventuallyShowRedirectNotification(request);
+        maybeShowRedirectNotification(request);
 
         // We try to trace the blocked redirect back to a link click or form
         // submission if we can. It may indicate, for example, a link that
@@ -317,7 +317,7 @@ RequestProcessor = (function(self) {
   /**
    * @param {RedirectRequest} aRequest
    */
-  function eventuallyShowRedirectNotification(aRequest) {
+  function maybeShowRedirectNotification(aRequest) {
     // Check if the request corresponds to a top-level document load.
     {
       let loadFlags = aRequest.httpResponse.httpChannel.loadFlags;
diff --git a/src/content/lib/utils.jsm b/src/content/lib/utils.jsm
index 530c776..58db1db 100644
--- a/src/content/lib/utils.jsm
+++ b/src/content/lib/utils.jsm
@@ -114,9 +114,8 @@ let Utils = (function() {
 
 
   /**
-   * This function returns and eventually creates a module's `internal`
-   * variable. The `internal` can be accessed from all submodules of that
-   * module (which might be in different files).
+   * Return a module's `internal` object, which is a singleton.
+   * The `internal` can be accessed from all submodules of that module.
    *
    * The `internal` is added to `self`, and as soon as all modules have been
    * loaded, i.e. when the startup functions are called, the `internal` is
diff --git a/src/content/main/pref-manager.jsm b/src/content/main/pref-manager.jsm
index f382f98..229d996 100644
--- a/src/content/main/pref-manager.jsm
+++ b/src/content/main/pref-manager.jsm
@@ -131,7 +131,7 @@ let PrefManager = (function() {
   };
 
 
-  function eventuallyHandleUninstallOrDisable(data, reason) {
+  function maybeHandleUninstallOrDisable(data, reason) {
     if (reason == C.ADDON_DISABLE || reason == C.ADDON_UNINSTALL) {
       // TODO: Handle uninstallation in bootstrap.js, not here, RP might be
       //       disabled when being uninstalled.
@@ -139,7 +139,7 @@ let PrefManager = (function() {
     }
   }
   ProcessEnvironment.addShutdownFunction(Environment.LEVELS.BACKEND,
-                                         eventuallyHandleUninstallOrDisable);
+                                         maybeHandleUninstallOrDisable);
 
   return self;
 }());
diff --git a/src/content/ui/frame.dom-content-loaded.js b/src/content/ui/frame.dom-content-loaded.js
index 1cc5019..bbb6dbb 100644
--- a/src/content/ui/frame.dom-content-loaded.js
+++ b/src/content/ui/frame.dom-content-loaded.js
@@ -59,8 +59,8 @@ let ManagerForDOMContentLoaded = (function() {
   function onDOMContentLoaded(event) {
     // TODO: This is getting called multiple times for a page, should only be
     // called once.
-    //    <--- the above comment is very old – is it still true that
-    //         onDOMContentLoaded is eventually called multiple times?
+    //    <--- the above comment is very old – is it (still) true that
+    //         onDOMContentLoaded is called multiple times?
     var doc = event.originalTarget;
     if (doc.nodeName != "#document") {
       // only documents
diff --git a/src/content/ui/menu.js b/src/content/ui/menu.js
index c53eb99..d831724 100644
--- a/src/content/ui/menu.js
+++ b/src/content/ui/menu.js
@@ -116,8 +116,7 @@ rpcontinued.menu = (function() {
 
 
   /**
-   * Removes all children from a list and eventually removes
-   * all event listeners.
+   * Remove all children from a list, and remove all event listeners.
    *
    * @param {Element} aList The list that should be emptied.
    */
diff --git a/src/content/ui/overlay.js b/src/content/ui/overlay.js
index de6d2e0..6872f49 100644
--- a/src/content/ui/overlay.js
+++ b/src/content/ui/overlay.js
@@ -403,7 +403,7 @@ rpcontinued.overlay = (function() {
    * @param {String} aUri
    * @param {Int} aMaxLength
    *
-   * @returns {String} the URI, eventually cropped
+   * @returns {String} the URI, possibly cropped
    *
    */
   function cropUri(aUri, aMaxLength) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/requestpolicy.git