[Pkg-mozext-commits] [tabmixplus] 21/26: Follow up bug 729011 - In fullscreen mode content.innerHeight is 1 pixel smaller than the screen height

David Prévot taffit at moszumanska.debian.org
Fri Mar 25 21:56:16 UTC 2016


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag 0.4.2.3pre.160319a1
in repository tabmixplus.

commit de77448576420523916d8ec7567b382c50de26af
Author: onemen <tabmix.onemen at gmail.com>
Date:   Sun Mar 13 22:02:23 2016 +0200

    Follow up bug 729011 - In fullscreen mode content.innerHeight is 1 pixel smaller than the screen height
---
 chrome/content/tabmix.js | 21 ++++-----------------
 chrome/skin/tab.css      |  6 +++++-
 2 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/chrome/content/tabmix.js b/chrome/content/tabmix.js
index 6d30226..c11f0cb 100644
--- a/chrome/content/tabmix.js
+++ b/chrome/content/tabmix.js
@@ -611,8 +611,8 @@ var TMP_eventListener = {
         fullScrToggler.addEventListener("mouseover", this._expandCallback, false);
         fullScrToggler.addEventListener("dragenter", this._expandCallback, false);
         fullScrToggler.hidden = true;
-        let bottombox = document.getElementById("browser-bottombox");
-        bottombox.appendChild(fullScrToggler);
+        let main = document.getElementById("main-window");
+        main.appendChild(fullScrToggler);
 
         if (Tabmix.isVersion(400)) {
           let $LF = '\n    ';
@@ -620,7 +620,7 @@ var TMP_eventListener = {
             'this._isChromeCollapsed = true;',
             'TMP_eventListener._updateMarginBottom(gNavToolbox.style.marginTop);' + $LF +
             '$&' + $LF +
-            'TMP_eventListener.toggleTabbarVisibility(false, aAnimate);'
+            'TMP_eventListener.toggleTabbarVisibility(false);'
           ).toCode();
         } else {
           Tabmix.changeCode(FullScreen, "FullScreen.sample")._replace(
@@ -700,7 +700,7 @@ var TMP_eventListener = {
   },
 
   // for tabs bellow content
-  toggleTabbarVisibility: function(aShow, aAnimate) {
+  toggleTabbarVisibility: function(aShow) {
     let fullScrToggler = document.getElementById("fullscr-bottom-toggler");
     if (TabmixTabbar.position != 1 || !fullScrToggler) {
       return;
@@ -715,19 +715,6 @@ var TMP_eventListener = {
       bottomToolbox.style.marginBottom =
           -(bottomToolbox.getBoundingClientRect().height +
           bottombox.getBoundingClientRect().height) + "px";
-
-      if (Tabmix.isVersion(400) && aAnimate &&
-          Services.prefs.getBoolPref("browser.fullscreen.animate")) {
-        // Hide the fullscreen toggler until the transition ends.
-        let listener = function() {
-          gNavToolbox.removeEventListener("transitionend", listener, true);
-          if (FullScreen._isChromeCollapsed)
-            fullScrToggler.hidden = false;
-        };
-        gNavToolbox.addEventListener("transitionend", listener, true);
-        fullScrToggler.hidden = true;
-      }
-
       // Until Firefox 41 changing the margin trigger resize event that calls
       // updateTabbarBottomPosition
       if (Tabmix.isVersion(410))
diff --git a/chrome/skin/tab.css b/chrome/skin/tab.css
index 20529a5..3ef5267 100644
--- a/chrome/skin/tab.css
+++ b/chrome/skin/tab.css
@@ -165,8 +165,12 @@ toolbar[mode="full"] .tabmix-button[type="menu"] {
 
 /* ::::: Fullscreen pseudo-toolbar ::::: */
 #fullscr-bottom-toggler {
+  bottom: 0;
+  left: 0;
+  width: 100%;
   height: 1px;
-  background: black;
+  position: fixed;
+  z-index: 2147483647;
 }
 
 /*

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git



More information about the Pkg-mozext-commits mailing list