[Pkg-mozext-commits] [tabmixplus] 46/73: Function isElementVisible can return wrong value when rect values are not integer

David Prévot taffit at moszumanska.debian.org
Mon May 9 02:30:55 UTC 2016


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit cff7b12c37d316f6af7321f79ade788ecfbb230b
Author: onemen <tabmix.onemen at gmail.com>
Date:   Thu Apr 21 20:32:08 2016 +0300

    Function isElementVisible can return wrong value when rect values are not integer
---
 chrome/content/tab/tab.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/chrome/content/tab/tab.js b/chrome/content/tab/tab.js
index b2ee329..edbb4bb 100644
--- a/chrome/content/tab/tab.js
+++ b/chrome/content/tab/tab.js
@@ -1076,13 +1076,14 @@ Tabmix.tabsUtils = {
     if (element.pinned)
       return true;
 
+    let round = val => Math.ceil(val);
     var [start, end] = this.tabBar.mTabstrip._startEndProps;
     var rect = this.tabBar.mTabstrip.scrollClientRect;
-    var containerStart = rect[start];
-    var containerEnd = rect[end];
+    var containerStart = round(rect[start]);
+    var containerEnd = round(rect[end]);
     rect = element.getBoundingClientRect();
-    var elementStart = rect[start];
-    var elementEnd = rect[end];
+    var elementStart = round(rect[start]);
+    var elementEnd = round(rect[end]);
 
     // we don't need the extra check with scrollContentRect
     // like in ensureElementIsVisible, the element will be invisible anyhow.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git



More information about the Pkg-mozext-commits mailing list