[Pkg-mozext-commits] [personasplus] 42/76: Custom persona with wrong image size is applied anyway

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository personasplus.

commit 2e7a1d80cafa6ed9d26e94e1c5d04476896f0160
Author: Baris Derin <baris at barisderin.com>
Date:   Wed Aug 17 10:21:54 2016 +0300

    Custom persona with wrong image size is applied anyway
    
    Custom persona with wrong image size is applied anyway
---
 extension/content/customPersonaEditor.js | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/extension/content/customPersonaEditor.js b/extension/content/customPersonaEditor.js
index 9808b3f..2a02ae6 100644
--- a/extension/content/customPersonaEditor.js
+++ b/extension/content/customPersonaEditor.js
@@ -228,16 +228,15 @@ var CustomPersonaEditor = {
               if (prompt.confirm(null, "Personas Plus", "Image must be 3000 pixels wide and 200 pixels tall. This image does not meet required specifications.\n\nWould you like to read more about how to create your own background theme?")) {
                   window.open("https://developer.mozilla.org/en-US/Add-ons/Themes/Background", '_blank');
               }
-              return;
+          } else {
+              // A random number is appended to avoid displaying a cached image
+              // after the image has been modified.
+              // See: https://bugzilla.mozilla.org/show_bug.cgi?id=543333
+              control.value = this.customPersona[property] =
+                  fp.fileURL.spec + "?" + Math.floor(Math.random() * 10000);
+              this._save();
           }
       }
-
-      // A random number is appended to avoid displaying a cached image
-      // after the image has been modified.
-      // See: https://bugzilla.mozilla.org/show_bug.cgi?id=543333
-      control.value = this.customPersona[property] =
-        fp.fileURL.spec + "?" + Math.floor(Math.random() * 10000);
-      this._save();
     }
   },
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/personasplus.git