[Pkg-mozext-commits] [tabmixplus] 33/147: Incompatibility problem with Stay-Open Menu, Undo closed tab from undo closed button list always open last closed tab. The original fix from changeset cc4c7716084d, regressed again by changeset f4f77cf52577

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit e8bcc854a8ea861dac38f6134a5c8c7707b8fa47
Author: onemen <tabmix.onemen at gmail.com>
Date:   Mon Nov 14 01:20:47 2016 +0200

    Incompatibility problem with Stay-Open Menu, Undo closed tab from undo closed button list always open last closed tab. The original fix from changeset cc4c7716084d, regressed again by changeset f4f77cf52577
---
 chrome/content/session/sessionStore.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/content/session/sessionStore.js b/chrome/content/session/sessionStore.js
index b2158f5..f996614 100644
--- a/chrome/content/session/sessionStore.js
+++ b/chrome/content/session/sessionStore.js
@@ -455,11 +455,11 @@ var TMP_ClosedTabs = {
 
   doCommand: function(command, where, item, keepMenuOpen) {
     const popup = item.parentNode;
-    const index = Number(item.value);
+    const index = Number(item.getAttribute("value"));
     this[command](where || index, index);
     const rePopulate = (keepMenuOpen || this.keepMenuOpen) && this.count > 0;
     if (rePopulate) {
-      if (command == "restoreTab") {
+      if (popup && command == "restoreTab") {
         this.populateUndoSubmenu(popup);
       }
     } else if (item.getAttribute("closemenu") == "none") {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git