[Pkg-mozext-commits] [tabmixplus] 94/147: Follow up bug 1330147 - removeObserver calls should not supply a third parameter

David Prévot taffit at moszumanska.debian.org
Sat Aug 5 15:27:40 UTC 2017


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit c2553bdbd7aaab5e6d4c99ad6310c7f462834210
Author: onemen <tabmix.onemen at gmail.com>
Date:   Sat Jan 14 10:22:15 2017 +0200

    Follow up bug 1330147 - removeObserver calls should not supply a third parameter
---
 .eslintrc.js                      | 1 +
 chrome/content/session/session.js | 2 +-
 modules/DynamicRules.jsm          | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 0d75a48..c80cff0 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -18,6 +18,7 @@ module.exports = {
     "tabmix/import-globals": 2,
     "tabmix/no-single-arg-cu-import": 2,
     "tabmix/no-import-into-var-and-global": 2,
+    "tabmix/no-useless-parameters": 2,
     "no-alert": 2,
     "no-array-constructor": 2,
     "no-bitwise": 0,
diff --git a/chrome/content/session/session.js b/chrome/content/session/session.js
index ad164a0..f0fd575 100644
--- a/chrome/content/session/session.js
+++ b/chrome/content/session/session.js
@@ -697,7 +697,7 @@ TabmixSessionManager = {
       obs.removeObserver(this, "sessionstore-browser-state-restored");
       obs.removeObserver(this, "quit-application-requested");
       obs.removeObserver(this, "browser-lastwindow-close-requested");
-      obs.removeObserver(this, "browser:purge-session-history", true);
+      obs.removeObserver(this, "browser:purge-session-history");
       if (Tabmix.isVersion(270))
         obs.removeObserver(this, "sessionstore-last-session-cleared");
     }
diff --git a/modules/DynamicRules.jsm b/modules/DynamicRules.jsm
index 627da67..51b8bd9 100644
--- a/modules/DynamicRules.jsm
+++ b/modules/DynamicRules.jsm
@@ -115,7 +115,7 @@ this.DynamicRules = {
   },
 
   onQuitApplication() {
-    Services.obs.removeObserver(this, "browser-window-before-show", false);
+    Services.obs.removeObserver(this, "browser-window-before-show");
     Services.obs.removeObserver(this, "quit-application");
     Prefs.removeObserver("", this);
     STYLENAMES.concat(EXTRAPREFS).forEach(function(pref) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git



More information about the Pkg-mozext-commits mailing list