patches

[Hendrik-Jan Heins]

Hello list,

I have been going over Mike's list with patches for Seamonkey, trying
to assess what they do and if they are needed. Below is the list of
patches and my comments on them. The only ones that are used in the
current build, are the ones with the remark "used". The patches
dedicated to specific systems are truly out of my league so no
comments there. If there's anyone out there that knows more about
them, please enlighten me on their function and if they are needed.
Any comments/help/hint/pointers on files with other comments are also
very welcome.
I compared the patches against Seamonkey 1.1a.

Here's the list:

[   ] 10_components_no_exec.dpatch         31-Aug-2006 14:06     1k
		What's the advantage?

[   ] 10_dash_workaround.dpatch            31-Aug-2006 14:07     1k
		Why?

[   ] 10_icons.dpatch                      31-Aug-2006 14:06     1k
		What exactly does this do? I'm already not using the icons in the package

[   ] 10_no_chromelist.dpatch              31-Aug-2006 14:06     1k
		Why is this better?

[   ] 15_overthespot.dpatch                31-Aug-2006 14:06     7k
		Not sure, should this be used?

[   ] 15_passwdmgr.dpatch                  31-Aug-2006 14:07     3k
		Already in there.

[   ] 18_arm_xpcom_unused_attribute.dpatch 31-Aug-2006 14:07     1k
[   ] 18_m68k_xpcom.dpatch                 31-Aug-2006 14:07     1k
[   ] 20_broken_perl.dpatch                31-Aug-2006 14:07     1k
		Already in there

[   ] 20_pangoxft.dpatch                   31-Aug-2006 14:07     1k
		Not needed

[   ] 20_visibility.dpatch                 31-Aug-2006 14:07     1k
	Not used Probably debatable

[   ] 25_entropy.dpatch                    31-Aug-2006 14:07     1k
		Used.

[   ] 25_gnome_helpers_with_params.dpatch  31-Aug-2006 14:07    14k
[   ] 25_xrender_bug_workaround.dpatch     31-Aug-2006 14:07     2k
		Cairo is used, so not needed

[   ] 28_ppc64_build.dpatch                31-Aug-2006 14:06     1k
[   ] 30_distclean.dpatch                  31-Aug-2006 14:07    10k
		Don't understand, why is this needed?

[   ] 30_embedding_tests.dpatch            31-Aug-2006 14:06     3k
		Don't understand, why is this needed?

[   ] 30_killAll.dpatch                    31-Aug-2006 14:07     1k
		Used

[   ] 32_print_command.dpatch              31-Aug-2006 14:06     1k
		Already in there

[   ] 35_crash_focus.dpatch                31-Aug-2006 14:07     4k
		Not sure this is needed; these files are extensively changed already

[   ] 38_arm_xpcom_optim.dpatch            31-Aug-2006 14:07     1k
[   ] 38_hppa_xpcom.dpatch                 31-Aug-2006 14:06     8k
[   ] 38_ia64_align.dpatch                 31-Aug-2006 14:07     3k
[   ] 38_mips64_build.dpatch               31-Aug-2006 14:06     1k
[   ] 38_mips_xpcom.dpatch                 31-Aug-2006 14:06    14k
[   ] 38_sparc64_unichar_alignment.dpatch  31-Aug-2006 14:06     6k
[   ] 38_unsupported_arch_build.dpatch     31-Aug-2006 14:07     1k
		Probably, not sure if it needs changing.

[   ] 60_xpcomstub.dpatch                  31-Aug-2006 14:07     1k
[   ] 65_mouse_buttons.dpatch              31-Aug-2006 14:07     1k
		No idea what the advantage is of this

[   ] 68_mips_performance.dpatch           31-Aug-2006 14:07     1k

[   ] 80_install_path.dpatch               31-Aug-2006 14:06     1k
		Not needed, it installs on the correct path
[   ] 80_libxpcom_hack.dpatch              31-Aug-2006 14:07     1k
		Don't think it's needed anymore

[   ] 80_no_sys_profile.dpatch             31-Aug-2006 14:06     1k
		Don't agree with what it fixes. I think new profiles depend on this.

[   ] 80_security_build.dpatch             31-Aug-2006 14:06     5k
		Is already at least partly in there, so not used

[   ] 80_uname.dpatch                      31-Aug-2006 14:07     2k
		Used

[   ] 80_zip.dpatch                        31-Aug-2006 14:06     4k
		Why?

[   ] 82_locale.dpatch                     31-Aug-2006 14:06     1k
		Already in there
[   ] 82_prefs.dpatch                      31-Aug-2006 14:07     3k
		Already in there
[   ] 82_ssl.dpatch                        31-Aug-2006 14:06     1k
		Already in there
[   ] 85_useragent.dpatch                  31-Aug-2006 14:06     2k
		Already in there

Hendrik-Jan