patches

[Mike Hommey]

On Wed, Sep 27, 2006 at 05:03:48PM +0200, Hendrik-Jan Heins <hjheins at gmail.com> wrote:
> Here's the list:
> 
> [   ] 10_components_no_exec.dpatch         31-Aug-2006 14:06     1k
> 		What's the advantage?

Having the .js files executable has no advantage. This patch install
them without the executable bit.

> [   ] 10_dash_workaround.dpatch            31-Aug-2006 14:07     1k
> 		Why?

Because of a silly dash bug (#337294). It is necessary for the build
not to fail when using dash as sh.

> [   ] 10_icons.dpatch                      31-Aug-2006 14:06     1k
> 		What exactly does this do? I'm already not using the icons 
> 		in the package

It installs the icons in the correct place (default.xpm and friends).

> [   ] 10_no_chromelist.dpatch              31-Aug-2006 14:06     1k
> 		Why is this better?

Because the chromelist.txt files are useless.

> [   ] 15_overthespot.dpatch                31-Aug-2006 14:06     7k
> 		Not sure, should this be used?

For people using stuff like scim and friends, yes.

> [   ] 20_visibility.dpatch                 31-Aug-2006 14:07     1k
> 	Not used Probably debatable

Another patch needs to be applied instead. See this changelog in
firefox 2.0 from experimental :
  * configure, configure.in: Apply patches from bz#334866, bz#319012 and
    bz#335949 + fixups to workaround gcc visibility hidden bugs, especially
    #331460 (an instance of which is actually still present in C++,
    see gcc#26905).

> [   ] 25_xrender_bug_workaround.dpatch     31-Aug-2006 14:07     2k
> 		Cairo is used, so not needed

Firefox and xulrunner too, use cairo.

> [   ] 30_distclean.dpatch                  31-Aug-2006 14:07    10k
> 		Don't understand, why is this needed?

So that make clean does its work.

> [   ] 30_embedding_tests.dpatch            31-Aug-2006 14:06     3k
> 		Don't understand, why is this needed?

To not build embedding tests, they are useless.

> [   ] 35_crash_focus.dpatch                31-Aug-2006 14:07     4k
> 		Not sure this is needed; these files are extensively changed 
> 		already

They are probably needed, I'll take a look at the code some time this
week.

> [   ] 38_unsupported_arch_build.dpatch     31-Aug-2006 14:07     1k
> 		Probably, not sure if it needs changing.

Unless this is applied in seamonkey, this is needed so that it builds
correctly on all debian architectures

> [   ] 65_mouse_buttons.dpatch              31-Aug-2006 14:07     1k
> 		No idea what the advantage is of this

For people that have mice with more than 3 or 5 buttons.

> [   ] 80_libxpcom_hack.dpatch              31-Aug-2006 14:07     1k
> 		Don't think it's needed anymore

It is needed if you build with -Wl,--as-needed for extension components
to work correctly.

> [   ] 80_no_sys_profile.dpatch             31-Aug-2006 14:06     1k
> 		Don't agree with what it fixes. I think new profiles depend 
> 		on this.

I don't know for seamonkey. Is it still based on xpfe or does it use the
toolkit ? If the latter:
- you probably don't need the update-seamonkey-chrome stuff anymore,
  because this is dealt with by the extensions manager
- you probably need this patch because the files in the system profile
  installed by the build system are useless with the new extensions
  manager and the toolkit

> [   ] 80_security_build.dpatch             31-Aug-2006 14:06     5k
> 		Is already at least partly in there, so not used

You may want to apply the SKIP_CHK part and the shlibsign stuff from
firefox or xulrunner rules files.

> [   ] 80_zip.dpatch                        31-Aug-2006 14:06     4k
> 		Why?

Explained on jabber ;)

Cheers

Mike