Bug#421542: nss: FTBFS on non-Linux: clean target fails due to unfixed upstream build system

[Michael Banck]

Package: nss
Version: 3.11.5-3
Severity: important

Hi,

nss fails to autobuild on non-Linux arches:

Automatic build of nss_3.11.5-3 on beethoven by sbuild/hurd-i386 85
Build started at 20070428-1546
******************************************************************************
[...]
Checking correctness of source dependencies...
Toolchain package versions: libc0.3-dev_2.5-4 gcc-4.1_4.1.1-21+hurd.1 g++-4.1_4.1.1-21+hurd.1 binutils_2.17-3 libstdc++6-4.1-dev_4.1.1-21+hurd.1 libstdc++6_4.1.1-21+hurd.1
Start building
------------------------------------------------------------------------------
gpg: Signature made Mon Apr  9 20:43:04 2007 CEST using DSA key ID 54FD2A58
gpg: Can't check signature: public key not found
dpkg-source: extracting nss in nss-3.11.5
dpkg-source: unpacking nss_3.11.5.orig.tar.gz
dpkg-source: applying /org/buildd/build/nss_3.11.5-3.diff.gz
dpkg-buildpackage: source package is nss
dpkg-buildpackage: source version is 3.11.5-3
dpkg-buildpackage: host architecture hurd-i386
dpkg-buildpackage: source version without epoch 3.11.5-3
 /usr/bin/fakeroot-tcp debian/rules clean
dh_testdir
dh_testroot
rm -f build-stamp install-stamp
/usr/bin/make -C mozilla/security/nss \
                clobber \
                clobber_dbm \
                clobber_coreconf \
                SOURCE_MD_DIR=/build/buildd/nss-3.11.5/mozilla/dist \
                DIST=/build/buildd/nss-3.11.5/mozilla/dist \
                BUILD_OPT=1 \

make[1]: Entering directory `/build/buildd/nss-3.11.5/mozilla/security/nss'
../coreconf/config.mk:71: ../coreconf/GNU0.3.mk: No such file or directory
/usr/bin/make: *** No rule to make target ../coreconf/GNU0.3.mk.  Stop.
make[1]: *** [../coreconf/GNU0.3.mk] Error 1
make[1]: Leaving directory `/build/buildd/nss-3.11.5/mozilla/security/nss'
make: *** [clean-patched] Error 2

This is because the build system only gets fixed up in the patches, and
the make clobber etc. is executed without a dash in front of it, not
ignoring failures.

FWIW, hurd-i386 builds fine otherwise with the attached patch by Samuel
Thibault taken from #419529.


Michael
-------------- next part --------------
#! /bin/sh /usr/share/dpatch/dpatch-run
## 39_hurd.dpatch by Samuel Thibault
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: GNU/Hurd support. #419529

@DPATCH@
--- nss/mozilla/dbm/src/ndbm.c.orig	2007-01-27 13:15:59.000000000 +0000
+++ nss/mozilla/dbm/src/ndbm.c	2007-01-27 13:16:37.000000000 +0000
@@ -67,7 +67,7 @@
 dbm_open(const char *file, int flags, int mode)
 {
 	HASHINFO info;
-	char path[MAXPATHLEN];
+	char path[strlen(file) + strlen(DBM_SUFFIX) + 1];
 
 	info.bsize = 4096;
 	info.ffactor = 40;
--- nss/mozilla/security/nss/lib/freebl/unix_rand.c.orig	2007-01-27 17:02:35.000000000 +0000
+++ nss/mozilla/security/nss/lib/freebl/unix_rand.c	2007-01-27 17:04:49.000000000 +0000
@@ -82,7 +82,8 @@
 
 #if defined(SCO) || defined(UNIXWARE) || defined(BSDI) || defined(FREEBSD) \
     || defined(NETBSD) || defined(NTO) || defined(DARWIN) || defined(OPENBSD) \
-    || defined(__FreeBSD_kernel__) || defined(__NetBSD_kernel__)
+    || defined(__FreeBSD_kernel__) || defined(__NetBSD_kernel__) \
+    || defined(__GNU__)
 #include <sys/times.h>
 
 #define getdtablesize() sysconf(_SC_OPEN_MAX)
--- nss/mozilla/security/nss/cmd/shlibsign/shlibsign.c.orig	2007-01-28 01:20:32.000000000 +0000
+++ nss/mozilla/security/nss/cmd/shlibsign/shlibsign.c	2007-01-28 01:21:01.000000000 +0000
@@ -163,6 +163,9 @@
 #ifdef USES_LINKS
     int ret;
     struct stat stat_buf;
+#ifndef MAXPATHLEN
+#define MAXPATHLEN 1024
+#endif
     char link_buf[MAXPATHLEN+1];
     char *link_file = NULL;
 #endif