Bug#421542: nss: FTBFS on non-Linux: clean target fails due to unfixed upstream build system

[Michael Banck]

On Mon, Apr 30, 2007 at 02:22:50AM +0200, Alexander Sack wrote:
> what do the uname variants give you on hurd? e.g.
> 
> # OS_ARCH       (from uname -r)
> # OS_TEST       (from uname -m)
> # OS_RELEASE    (from uname -v and/or -r)

buildd at beethoven:~$ uname -m
i686-AT386
buildd at beethoven:~$ uname -v
GNU-Mach 1.3.99/Hurd-0.3
buildd at beethoven:~$ uname -r
0.3
buildd at beethoven:~$ uname -s
GNU

> On Mon, Apr 30, 2007 at 01:25:15AM +0200, Michael Banck wrote:
> > --- nss/mozilla/dbm/src/ndbm.c.orig	2007-01-27 13:15:59.000000000 +0000
> > +++ nss/mozilla/dbm/src/ndbm.c	2007-01-27 13:16:37.000000000 +0000
> > @@ -67,7 +67,7 @@
> >  dbm_open(const char *file, int flags, int mode)
> >  {
> >  	HASHINFO info;
> > -	char path[MAXPATHLEN];
> > +	char path[strlen(file) + strlen(DBM_SUFFIX) + 1];
> >  
> >  	info.bsize = 4096;
> >  	info.ffactor = 40;
> 
> hmmm ...
> 
> > --- nss/mozilla/security/nss/lib/freebl/unix_rand.c.orig	2007-01-27 17:02:35.000000000 +0000
> > +++ nss/mozilla/security/nss/lib/freebl/unix_rand.c	2007-01-27 17:04:49.000000000 +0000
> > @@ -82,7 +82,8 @@
> >  
> >  #if defined(SCO) || defined(UNIXWARE) || defined(BSDI) || defined(FREEBSD) \
> >      || defined(NETBSD) || defined(NTO) || defined(DARWIN) || defined(OPENBSD) \
> > -    || defined(__FreeBSD_kernel__) || defined(__NetBSD_kernel__)
> > +    || defined(__FreeBSD_kernel__) || defined(__NetBSD_kernel__) \
> > +    || defined(__GNU__)
> >  #include <sys/times.h>
> >  
> >  #define getdtablesize() sysconf(_SC_OPEN_MAX)
> 
> will this include linux now?

No, __GNU__ identifies the GNU/Hurd system, this is not defined on
GNU/Linux (which uses __Linux__ for this).

> > --- nss/mozilla/security/nss/cmd/shlibsign/shlibsign.c.orig	2007-01-28 01:20:32.000000000 +0000
> > +++ nss/mozilla/security/nss/cmd/shlibsign/shlibsign.c	2007-01-28 01:21:01.000000000 +0000
> > @@ -163,6 +163,9 @@
> >  #ifdef USES_LINKS
> >      int ret;
> >      struct stat stat_buf;
> > +#ifndef MAXPATHLEN
> > +#define MAXPATHLEN 1024
> > +#endif
> >      char link_buf[MAXPATHLEN+1];
> >      char *link_file = NULL;
> >  #endif
> 
> ... so you don't have MAXPATHLEN ... why is it that way?

Because there are no arbitrary system limits on the GNU system.  
 

cheers,

Michael