Bug#553593: Acknowledgement (xulrunner: Please port to sh4)

Mike Hommey mh at glandium.org
Tue Dec 15 08:49:41 UTC 2009


Hi,

On Tue, Dec 08, 2009 at 09:52:28AM +0900, Nobuhiro Iwamatsu wrote:
> Hi, Mike.
> 
> 2009/12/7 Mike Hommey <mh at glandium.org>:
> > Hi Iwamatsu-san
> >
> > On Mon, Dec 07, 2009 at 10:21:22AM +0900, Nobuhiro Iwamatsu wrote:
> >> Hi,
> >>
> >> > I am now trying to run Debian on Renesas SH CPU(sh4)[0].
> >> > Current postgresql package doesn't support sh4[1].
> >> > I made a patch to revise to be able to build.
> >> > I attach patch. Would you apply it?
> >>
> >> > [0]: http://buildd.debian-ports.org/status/architecture.php?suite=unstable&a=sh4&buildd=
> >> > [1]: http://buildd.debian-ports.org/fetch.php?pkg=xulrunner&arch=sh4&ver=1.9.1.4-1&stamp=1257038103&file=log&as=raw
> >>
> >> When will you apply this patch?
> >> Or do you have the plan applying?
> >
> > I'm sorry, this bug totally dropped off my attention. I'll try to check
> > the patch this week.

A bit late, but here I am.

Here are my first obvious comments, before even trying to send that
upstream:
- Please add the license boilerplate at the top of the files you add,
  with proper contributor listing. (See the files in the same directory
  for examples)
- ifeq (sh,$(findstring sh,$(OS_TEST))) seems a bit risky. What is the
  platform name ? sh only ? filter would be better than findstring,
  then. If it is shsomething, then filter sh% would be better.

Now, for a stupid question, does that add support for all the SuperH
processors (from SH-1), a subset (as SH-1 and 2 were pretty limited, I
would assume from SH-3), or only the latest ones (SH-4 ? SH-5 ?)
Would it build on the netbsd port on dreamcast ?

Finally, I see there currently is some support for sh/sh3/sh4 in nspr
and nss, is that enough?

Cheers,

Mike





More information about the pkg-mozilla-maintainers mailing list