New component in xulrunner

[Mike Hommey]

On Tue, Feb 02, 2010 at 07:19:08PM +0100, Axel Beckert wrote:
> Hi,
> 
> On Tue, Feb 02, 2010 at 10:27:55AM +0100, Mike Hommey wrote:
> > Oh, I forgot, in 1.9.1.6-2, too, is another new component, that is able
> > to dump addons information (plugins and extensions), and a reportbug
> > helper script that can be hooked in a reportbug script like the
> > following:
> > 
> > if [ -x /usr/lib/xulrunner-1.9.1/reportbug-helper-script ]; then
> >         /usr/lib/xulrunner-1.9.1/reportbug-helper-script $binary
> > fi
> > 
> > where $binary is the binary name of the xul application.
> 
> Played around with it and conkeror a little bit. Here's a first
> feedback:
> 
> -dump-addons-info seems to be passed down to conkeror's command line
> parser although upstream says "conkeror's command-line processor has
> very low precedence, so any other handlers will run first. conkeror
> should not even see the switches that other handlers consume".
> 
> Is this on purpose?

Can you try to patch /usr/lib/xulrunner-1.9.1/components/addonsInfo.js
with the attached patch and see if it works as expected ?

Mike
-------------- next part --------------
diff --git a/debian/extra-stuff/addonsInfo.js b/debian/extra-stuff/addonsInfo.js
index 6276939..f00d37d 100644
--- a/debian/extra-stuff/addonsInfo.js
+++ b/debian/extra-stuff/addonsInfo.js
@@ -75,6 +75,13 @@ addonsInfoHandler.prototype = {
     var out;
     try {
       path = cmdLine.handleFlagWithParam("dump-addons-info", false);
+    } catch(e) {
+      if (!cmdLine.handleFlag("dump-addons-info", false))
+        return;
+    }
+
+    cmdLine.preventDefault = true;
+
       if (path) {
         var file = Cc["@mozilla.org/file/local;1"]
                    .createInstance(Ci.nsILocalFile);
@@ -85,15 +92,8 @@ addonsInfoHandler.prototype = {
         out = Cc["@mozilla.org/intl/converter-output-stream;1"]
               .createInstance(Ci.nsIConverterOutputStream);
         out.init(outstream, "UTF-8", 0, 0);
-      }
-    } catch (e) {
+    } else
       out = new dumper();
-    }
-
-    if (! out)
-      return;
-
-    cmdLine.preventDefault = true;
 
     try {
       dump_extensions(out);