Bug#568004: Iceweasel - no search suggestions in the search-box

[Mike Hommey]

On Thu, Feb 04, 2010 at 03:08:31PM -0200, Rogério Brito wrote:
> Package: iceweasel
> Severity: normal
> 
> Hi, people.
> 
> I had this problems during the past days and today I got really annoyed
> with it.
> 
> I unstalled (purged, actually) everything that had anything to do with
> mozilla and tried to get firefox from the nightly builds from ubuntu,
> but it lacked any of those automated searches.
> 
> Then, I tried to to understand the format of some of those and I
> discovered that the ones attached (taken from mozilla.org, with some
> minor modifications *do* work).
> 
> One thing to note here is that the only other one that I tried
> (wikipedia) worked fine, without any problems, which narrowed it down to
> google's.
> 
> Perhaps they have changed their interface or the .xml file shipped with
> iceweasel is not complete with the suggestions foo thing, as given here:
> 
> ,----
> | <os:Url type="application/x-suggestions+json" method="GET" template="http://suggestqueries.google.com/complete/search?output=firefox&amp;client=firefox&amp;hl=en&amp;q={searchTerms}"/>
> `----
> 
> (I just hardcoded the locale above, but it should, perhaps, work fine
> without it---I guess).

Okay, I actually can reproduce the problem, and the problem can be
summarized with what the error console displays:
Error: JSON.parse
Source File: file:///usr/lib/iceweasel/xulrunner/components/nsSearchSuggestions.js Line: 525

It appears that if client=firefox, the json is correct, and if
client=somethingelse, the json is broken. It also appears that not using
client at all makes it work too.

I'll work around this in next release.

Mike