Bug#603412: iceweasel: "Addons package information" in bug reports contains full list of installed packages

[Luca Capello]

reassign 603412 xulrunner-1.9.1
found 603412 1.9.1.16-6
affects 603412 xulrunner-2.0
affects 603412 xulrunner-5.0
affects 603412 iceweasel
affects 603412 conkeror
tags 603412 + patch
thanks

Hi there!

On Mon, 15 Nov 2010 17:16:05 +0100, Josh Triplett wrote:
> On Sat, Nov 13, 2010 at 11:27:04PM +0100, Mike Hommey wrote:
>> On Sat, Nov 13, 2010 at 12:02:51PM -0800, Josh Triplett wrote:
>> > Package: iceweasel

Reassigning to the correct package with the first version I found
according to #623839 and adding information about affected packages.

>> > The "Addons package information" section in bug reports contains a full
>> > list of installed packages, rather than just addon-related packages.
>> > See the example below, trimmed to just the beginning and end.
>> 
>> This is due to the component getting this information not working with
>> the new extensions manager yet.

I do not have any extensions installed (conkeror_0.9.3+git110602-1
here), but I still get the full list of packages as Josh or Helge
Kreutzmann in:

  <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=623839#20>

It seems the problem has nothing to do with xulrunner at all, but it is
linked to `dpkg -l`, which defaults to list all the installed packages
if no argument is given:

--8<---------------cut here---------------start------------->8---
dpkg-query(1) -- 2010-03-07 -- Debian Project -- dpkg suite

NAME
	dpkg-query - a tool to query the dpkg database

SYNOPSIS
	dpkg-query [option...] command

DESCRIPTION
	dpkg-query  is a  tool  to show  information about  packages
	listed in the dpkg database.

COMMANDS

	-l, --list [package-name-pattern...]
		List   packages   matching   given   pattern.   If   no
		package-name-pattern  is given,  list  all packages  in
		/var/lib/dpkg/status,  excluding  the  ones  marked  as
		not-installed  (i.e. those  which have  been previously
		purged).   [...]
--8<---------------cut here---------------end--------------->8---

The patch is easy, given that we simply need to check if "$tmp2" is
empty or not before generating the list:

--8<---------------cut here---------------start------------->8---
--- /usr/lib/xulrunner-1.9.1/reportbug-helper-script.OLD	2011-07-01 12:19:50.000000000 +0200
+++ /usr/lib/xulrunner-1.9.1/reportbug-helper-script	2011-07-19 21:10:37.279165990 +0200
@@ -16,6 +16,6 @@
 
 echo >&3
 echo -- Addons package information >&3
-awk -F": " '{ print $1 }' "$tmp2" | sort -u | COLUMNS=79 xargs dpkg -l 2> /dev/null | grep ^i >&3
+[ -s "$tmp2" ] && awk -F": " '{ print $1 }' "$tmp2" | sort -u | COLUMNS=79 xargs dpkg -l 2> /dev/null | grep ^i >&3
 
 rm -f "$tmp" "$tmp2"
--8<---------------cut here---------------end--------------->8---

> As a stopgap measure, you might consider limiting the list of packages to xul* and
> other key prefixes.

In an ideal world the prefix should be xul-* only, I guess, but how do
you catch non-standard names, like the following on a default sid?
=====
ii  browser-plugin 0.8.10~git2011 GNU Shockwave Flash (SWF) player - Plugin fo
ii  iceweasel      3.5.19-2       Web browser based on Firefox
ii  rhythmbox-plug 0.12.8-3       plugins for rhythmbox music player
ii  totem-mozilla  2.30.2-6       Totem Mozilla plugin
=====

NB1, the output above is generated by removing all the ">&3" references
     in /usr/lib/xulrunner-1.9.1/reportbug-helper-script and then
     calling it with "iceweasel" as argument.  When done with
     iceweasel_5.0-3 and xulrunner-5.0_5.0-3 the output is the same but
     the iceweasel line :-)

NB2, according to one of the dpkg's author you should really use
     dpkg-query instead (ATM nothing changes WRT the output, tested with
     xulrunner-1.9.1_1.9.1.19-3 and xulrunner-5.0_5.0-3):

       <http://lists.debian.org/msgid-search/%3c20110303134551.GD11723%40rivendell.home.ouaza.com%3e>

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20110719/b6c29109/attachment-0001.pgp>