Bug#642773: Session restore not automatic anymore

[Josh Triplett]

On Tue, Sep 27, 2011 at 08:27:10AM +0200, Mike Hommey wrote:
> On Mon, Sep 26, 2011 at 10:42:40PM -0700, Josh Triplett wrote:
> > On Mon, Sep 26, 2011 at 07:38:28PM +0200, Mike Hommey wrote:
> > > On Mon, Sep 26, 2011 at 10:34:49AM -0700, Josh Triplett wrote:
> > > > On Mon, Sep 26, 2011 at 06:14:14PM +0200, Mike Hommey wrote:
> > > > > On Mon, Sep 26, 2011 at 08:20:18AM -0700, Josh Triplett wrote:
> > > > > > On Mon, Sep 26, 2011 at 08:46:42AM +0200, Mike Hommey wrote:
> > > > > > > On Sun, Sep 25, 2011 at 12:51:20PM -0700, Josh Triplett wrote:
> > > > > > > > On Sun, Sep 25, 2011 at 09:54:55AM +0200, Mike Hommey wrote:
> > > > > > > > > On Sat, Sep 24, 2011 at 04:31:01PM -0700, Josh Triplett wrote:
> > > > > > > > > > Package: iceweasel
> > > > > > > > > > Version: 6.0.2-1
> > > > > > > > > > Severity: normal
> > > > > > > > > > 
> > > > > > > > > > Previously, when I quit iceweasel with ctrl-Q, I'd get my session back
> > > > > > > > > > next time I ran it.  (By contrast, if I closed iceweasel by closing the
> > > > > > > > > > last tab, I wouldn't, which worked out perfectly.)  Now, I have to
> > > > > > > > > > manually either open about:home (I normally use a blank homepage) and
> > > > > > > > > > click on "restore previous session", or use Iceweasel->History->Restore
> > > > > > > > > > Previous Session.
> > > > > > > > > > 
> > > > > > > > > > I don't mind if this requires an extra click, but I don't want to have
> > > > > > > > > > to dig through the menus or open about:home to get to it.  Perhaps
> > > > > > > > > > iceweasel could automatically show a page with the "restore session"
> > > > > > > > > > button on it when launched with a saved session, or alternatively
> > > > > > > > > > perhaps it could go straight to the "what pages would you like to
> > > > > > > > > > restore" page.  Either way, I'd like to have session restoration become
> > > > > > > > > > a lot more automatic.
> > > > > > > > > 
> > > > > > > > > Your settings must be wrong, because I've been doing this since well
> > > > > > > > > before iceweasel 4, and it still works here.
> > > > > > > > > Please check your startup preferences under the General category of the
> > > > > > > > > preferences dialog.
> > > > > > > > 
> > > > > > > > I've had the same startup preferences since before iceweasel 3:
> > > > > > > > user_pref("browser.startup.page", 0); AKA "Show a blank page".  Session
> > > > > > > > restore used to work automatically for me: if the browser crashed, or I
> > > > > > > > closed the browser without closing individual tabs (Ctrl-Q, Alt-F4,
> > > > > > > > closing via the window manager), the session would restore automatically
> > > > > > > > on next launch.  Recently, though, this behavior changed: I still get
> > > > > > > > the session restore behavior if Firefox *crashes*, but not if I close it
> > > > > > > > with tabs open.
> > > > > > > 
> > > > > > > And that's the expected behaviour.
> > > > > > > If you want the session to always be restored, choose "Show my windows
> > > > > > > and tabs from last time".
> > > > > > 
> > > > > > That doesn't have the right effect either.  If I set it to "Show my
> > > > > > windows and tabs from last time" (setting browser.startup.page to 3),
> > > > > > then closing the browser by closing all of the tabs individually causes
> > > > > > it to open up next time with the last tab I closed.  That doesn't match
> > > > > > the ideal behavior I used to have, where closing all the individual tabs
> > > > > > would cause the browser to re-open with no session, but closing multiple
> > > > > > tabs at once (Ctrl-Q, Alt-F4, window manager close, kill/crash) would
> > > > > > preserve them all in the session and restore them later.  (And I used to
> > > > > > have that behavior with browser.startup.page set to 0.)
> > > > > 
> > > > > That's not possible. With browser.startup.page set to 0, you always get
> > > > > a blank tab, whatever the status was when you closed. When
> > > > > browser.tabs.warnOnClose is true (which is the default), it also asks
> > > > > you if you want to save your tabs before quitting, and if you do, it
> > > > > switches browser.startup.page to 3.
> > > > 
> > > > I have browser.tabs.warnOnClose set to true, but Firefox doesn't prompt
> > > > when closing, and doesn't save the tabs.  I'd sure like it if it did.
> > > > 
> > > > > Anyways, what you want is to set browser.tabs.closeWindowWithLastTab to
> > > > > false.
> > > > 
> > > > Ow, no, I definitely don't want *that*.
> > > 
> > > Oh yes you do, your complaint is that when closing the last tab and
> > > starting the browser again, you get that last tab instead of a blank
> > > tab. browser.tabs.closeWindowWithLastTab to false would get you in a
> > > state where you have a blank tab before actually closing the browser.
> > 
> > It also means I can't just hit Ctrl-W to close the browser, so no. :)
> 
> Just use ctrl-q.

Which would then lead back to the original problem, namely that I don't
want the browser to remember the session when I closed it by closing the
last tab.  But ignoring that for now...

> > I'd like to have the behavior you describe as associated with
> > browser.tabs.warnOnClose, which doesn't seem to work as you described.
> 
> It does.

Perhaps you could clarify?  You said:
> When
> browser.tabs.warnOnClose is true (which is the default), it also asks
> you if you want to save your tabs before quitting, and if you do, it
> switches browser.startup.page to 3.

However, I have browser.tabs.warnOnClose set to true, and when I quit,
Iceweasel does *not* ask me if I want to save my tabs before quitting,
nor does it preserve the session.

- Josh Triplett