Bug#642773: Session restore not automatic anymore

[Josh Triplett]

On Wed, Sep 28, 2011 at 06:12:06PM +0200, Mike Hommey wrote:
> On Wed, Sep 28, 2011 at 08:38:25AM -0700, Josh Triplett wrote:
> > On Tue, Sep 27, 2011 at 02:29:20PM +0200, Mike Hommey wrote:
> > > On Tue, Sep 27, 2011 at 05:24:49AM -0700, Josh Triplett wrote:
> > > > On Tue, Sep 27, 2011 at 09:11:31AM +0200, Mike Hommey wrote:
> > > > > On Mon, Sep 26, 2011 at 11:34:24PM -0700, Josh Triplett wrote:
> > > > > > Perhaps you could clarify?  You said:
> > > > > > > When
> > > > > > > browser.tabs.warnOnClose is true (which is the default), it also asks
> > > > > > > you if you want to save your tabs before quitting, and if you do, it
> > > > > > > switches browser.startup.page to 3.
> > > > > > 
> > > > > > However, I have browser.tabs.warnOnClose set to true, and when I quit,
> > > > > > Iceweasel does *not* ask me if I want to save my tabs before quitting,
> > > > > > nor does it preserve the session.
> > > > > 
> > > > > Mmmm look like the default changed and you need to set
> > > > > browser.showQuitWarning.
> > > > 
> > > > Ah!  That does seem to work, almost.  Setting that to true gave me the
> > > > "Do you want Iceweasel to save your tabs for the next time it starts?"
> > > > dialog with an option to either "Quit" or "Save and Quit", and choosing
> > > > the latter preserves my open tabs and automatically restores them next
> > > > time I run Iceweasel.
> > > > 
> > > > However, checking the "Do not ask next time" box did not have any
> > > > effect.  I checked the box and clicked "Save and Quit", which if it
> > > > worked would do exactly what I'd like (preserve/restore open tabs
> > > > automatically on Ctrl-Q without asking), but the dialog continues to
> > > > appear (with the checkbox unchecked).
> > > 
> > > That would be exactly the same behaviour as the one you were complaining
> > > about in the first place.
> > 
> > Hrm?  "Preserve/restore open tabs automatically on Ctrl-Q without
> > asking" sounds like exactly the behavior I'd like to have.  Turning on
> > showQuitWarning gives me almost exactly the behavior I'd like, except
> > for having a prompt to save tabs or not.  I assumed that checking the
> > "Do not ask next time" box and clicking "Save and Quit" would cause
> > "Save and Quit" to become the default when I hit Ctrl-Q; however, that
> > checkbox didn't seem to have any effect.
> 
> Provided this would work (and it's weird that it doesn't, but that's
> maybe not surprising considering we've been touching prefs with no
> corresponding UI), you'd end up exactly with the behaviour you had to
> begin with: Ctrl-Q keeps the session when you restart, and closing the
> last tab with Ctrl-W keeps the last tab when you restart.
> I don't believe there is any sane way to do what you are asking for.

If you ignore the prompt and the non-working "Do not ask next time"
checkbox to make it go away, showQuitWarning actually has exactly the
behavior I want (and used to have): if I hit Ctrl-Q, I get prompted to
save my tabs, and they'll get automatically restored; closing the last
tab does not trigger this dialog, and does not save the one tab as a
session.

- Josh Triplett