Bug#682371: StartupWMClass=Firefox-bin

[Zebedee]

In the iceweasel_3.5.16-13_i386.deb package, from Debian 6 Squeeze (which is not the current version of Iceweasel in Squeeze stable) I noted that there was an error in the  file usr/share/applications/iceweasel.desktop.
The line :
StartupWMClass=Firefox-bin
is incorrect as far as I can determine.
Using the command 'xprop' in a small terminal window with Iceweasel open and visible on screen in a window behind, and then left clicking the open Iceweasel window reveals this result:
WM_CLASS(STRING) = "Navigator", "Iceweasel"The Free Desktop webpage on the subject, Recognized desktop entry keys, says:
StartupWMClass
If specified, it is known that the application will map at least one
			window with the given string as its WM class or WM name hint (see the Startup Notification Protocol Specification for more details). 

This would suggest the correct entry in the iceweasel.desktop file should be changed to read in this case :
StartupWMClass=Iceweasel

More detail can be found at :
http://standards.freedesktop.org/startup-notification-spec/startup-notification-0.1.txt
(excerpts)

WMCLASS a string to match against the "resource name" or "resource class" hints. If this key is present, the launchee will most likely not send a "remove" message on its own. If the desktop environment detects a toplevel window mapped with this name or class, it should send a "remove" message for  the startup sequence. Note that the class hint is in Latin-1, so the value of this key must be converted to  Latin-1 before strcmp'ing it with the window class/name.  (Though in all known cases only ASCII is involved so it  doesn't matter.)

- the launchee code is responsible for sending a "remove"  message to end the launch sequence, unless the WMCLASS  key was set.

I think this could mean this bug in the iceweasel.desktop file is related to and may well be the cause of bug #523824.
Although StartupWMClass is an optional entry for a desktop file, the omission of a correct entry might lead to occasional problems when shutting down the computer, as a warning message may appear about an unknown application still running. This is apparently due to some process started by Mozilla Firefox / Iceweasel that is not properly closed. It would appear from what I have read that the StartupWMClass entry should allow the desktop to close any child processes when the main window is closed and avoid this situation. 

Yours sincerely,
Zebedee.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20121019/254cf1f8/attachment.html>