Bug#749084: iceweasel: Shipped DuckDuckGo, Wikipedia, Amazon searches have no icons

[Jason Fergus]

On Fri, 23 May 2014 23:40:32 +0200 Ralf Jung <post at ralfj.de> wrote:
> Package: iceweasel
> Version: 29.0.1-1
> Severity: normal
> 
> Dear Maintainer,
> 
> The shipped DuckDuckGo, Wikipedia, Amazon searches have no icons.
> Steps to reproduce: Just create a new, fresh profile and open the search bar menu.
> The mentioned three entries have no icons.
> 
> To make things worse, it is also not possible to use the search entry from DuckDuckGo themselves
> to get a fixed icon:
> After removing the entry Debian provides, when I try to add the one from duckduckgo.com or
> also from the Mozilla "Add more searches" page, I always get the error that 
> "an engine with the same name already exists". Which is clearly wrong, I just removed it, but
> it won't let me add DuckDuckGo again. So all I can do is reset my search engines to default,
> which brings them back with a broken icon.
> 
> Kind regards
> Ralf
> 
> -- Package-specific info:
> 

The fix, it seems, is to not use the URL for the icon, but instead have a base64 encoded image in the xml files.

The files I speak of that have this bug are;
/etc/iceweasel/searchplugins/locale/en-US/amazondotcom.xml
/etc/iceweasel/searchplugins/common/duckduckgo.xml
/etc/iceweasel/searchplugins/locale/en-US/wikipedia.xml

This isn't really a bug, but 'by design'.  Firefox won't fetch URL favicon.ico files that are larger than 10,000 Bytes.
The Icons are 17542 (amazon), 32988 (DuckDuckGo), and 15086 (Wikipedia).

I'll attach the three files, though if you don't trust my work (after all, there are redirection nastiness that can
be done here), then it's easy enough to recreate these.  Just follow the links in the xml files, download the
favicon.ico file, then run 'base64 -w 0 favicon.ico' and it'll output a bunch of 'garbage'.  Copy that into the xml
file as I've done with the tags <Image width="16" height="16">data:image/x-icon;base64,</Image> around them.  
The actual base64 data needs to go after the comma and before the < as in the attachments.

I'm not sure how the maintainer can fix these, unless he just takes the modified xml files and replaces the ones that
attempt to get the URL, since it's a non-configurable limit in Firefox/Iceweasel (at least as far as I could find.)



-------------- next part --------------
A non-text attachment was scrubbed...
Name: duckduckgo.xml
Type: application/xml
Size: 1767 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20140811/826eac1c/attachment-0003.xml>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amazondotcom.xml
Type: application/xml
Size: 24495 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20140811/826eac1c/attachment-0004.xml>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wikipedia.xml
Type: application/xml
Size: 21394 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20140811/826eac1c/attachment-0005.xml>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20140811/826eac1c/attachment-0001.sig>