Bug#741138: iceweasel: "Warn me when closing multiple tabs" broken in private browsing mode

[Michael Gold]

Package: iceweasel
Version: 24.3.0esr-1

The "Tabs / Warn me when closing multiple tabs" preference doesn't do
anything in private browsing mode.  To reproduce, open several private
tabs in a window, then close the window.  No warning is shown.

Setting browser.showQuitWarning to any string will cause the warning to
appear when the browser's last window is being closed, but no warning is
shown otherwise.

In browser/components/nsBrowserGlue.js I see this code:
  // Never show a prompt inside private browsing mode
  if (allWindowsPrivate)
    return;
But this behaviour is bizarre and not described in the preferences screen.
I have Iceweasel set to always use private browsing mode, so there's no
way this preference would ever do anything.  I think it's more important
to prompt in private mode, since there's no history or session-store to
get the windows back.

There should at least be an about:config option allowing a prompt in
this case.  Or the preferences screen could have a dropdown list, e.g.,
"Warn me when closing multiple tabs
   * Never
   * Except in private browsing mode
   * Always"

- Michael


-- Package-specific info:


-- Addons package information

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.12-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages iceweasel depends on:
ii  debianutils         4.4
ii  fontconfig          2.11.0-5
ii  libc6               2.17-97
ii  libgdk-pixbuf2.0-0  2.30.5-1
ii  libglib2.0-0        2.38.2-5
ii  libgtk2.0-0         2.24.22-1
ii  libnspr4            2:4.10.3-1
ii  libnspr4-0d         2:4.10.3-1
ii  libsqlite3-0        3.8.3.1-1
ii  libstdc++6          4.8.2-16
ii  procps              1:3.3.9-4
ii  xulrunner-24.0      24.3.0esr-1

iceweasel recommends no packages.

Versions of packages iceweasel suggests:
pn  fonts-mathjax          <none>
pn  fonts-oflb-asana-math  <none>
pn  fonts-stix | otf-stix  <none>
ii  libgssapi-krb5-2       1.12+dfsg-2
pn  mozplugger             <none>

Versions of packages xulrunner-24.0 depends on:
ii  libasound2                1.0.27.2-3
ii  libatk1.0-0               2.10.0-2
ii  libbz2-1.0                1.0.6-5
ii  libc6                     2.17-97
ii  libcairo2                 1.12.16-2
ii  libdbus-1-3               1.8.0-2
ii  libdbus-glib-1-2          0.102-1
ii  libevent-2.0-5            2.0.21-stable-1
ii  libfontconfig1            2.11.0-5
ii  libfreetype6              2.5.2-1
ii  libgcc1                   1:4.8.2-16
ii  libgdk-pixbuf2.0-0        2.30.5-1
ii  libglib2.0-0              2.38.2-5
ii  libgtk2.0-0               2.24.22-1
ii  libhunspell-1.3-0         1.3.2-6
ii  libmozjs24d               24.3.0esr-1
ii  libnspr4                  2:4.10.3-1
ii  libnss3                   2:3.15.4-2
ii  libpango-1.0-0            1.36.2-2
ii  libsqlite3-0              3.8.3.1-1
ii  libstartup-notification0  0.12-3
ii  libstdc++6                4.8.2-16
ii  libvpx1                   1.3.0-2
ii  libx11-6                  2:1.6.2-1
ii  libxext6                  2:1.3.2-1
ii  libxrender1               1:0.9.8-1
ii  libxt6                    1:1.1.4-1
ii  zlib1g                    1:1.2.8.dfsg-1

Versions of packages xulrunner-24.0 suggests:
ii  libcanberra0  0.30-2
pn  libgnomeui-0  <none>

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozilla-maintainers/attachments/20140308/9417fc63/attachment.sig>