Bug#741245: [hppa][patch] icedove : FTBFS on hppa, patch attached.
c.schoenert at t-online.de
Sat Mar 15 19:58:07 UTC 2014
tags 741245 pending
On Mon, Mar 10, 2014 at 07:40:44PM +0100, Helge Deller wrote:
> >> --- iceweasel-24.2.0esr.orig/js/src/gc/RootMarking.cpp
> >> +++ iceweasel-24.2.0esr/js/src/gc/RootMarking.cpp
> >> @@ -320,7 +320,7 @@ MarkConservativeStackRoots(JSTracer *trc
> >> uintptr_t *stackMin, *stackEnd;
> >> #if JS_STACK_GROWTH_DIRECTION > 0
> >> - stackMin = rt->nativeStackBase;
> >> + stackMin = reinterpret_cast<uintptr_t *>(rt->nativeStackBase);
> > This looks probably o.k. to me. But I haven't tested it for amd64/i386.
> > Should work.
> This is inside the
> #if JS_STACK_GROWTH_DIRECTION > 0
> Only the parisc (=hppa) and the "metag" processor architecture do have a stack with grows upwards.
> x86_64, ia64, sparc and on all others the stack grows down.
> That means, this code change will not affect any other debian architecture and this is the
> reason that this FTBFS was not detected earlier.
> The metag arch isn't supported by debian yet AFAIK.
I made some testing builds and Icedove works as expected. I commited the
changes based on the patch you appended previously and add you as author
locally. Is this o.k. for you?
Christoph or Guido will pick this commit before they will upload one of
the next versions I think.
More information about the pkg-mozilla-maintainers