Bug#795331: iceweasel: backport/security builds (bundled libvpx) FTBFS on armhf

[Mike Hommey]

On Thu, Aug 13, 2015 at 12:05:19AM +0100, Simon McVittie wrote:
> Package: iceweasel
> Version: 38.1.1esr-1
> Severity: important
> 
> [X-Debbugs-Cc: debian-arm to get an expert opinion on how the ABIs fit
> together]
> 
> As described on <https://bugs.debian.org/795079>, a rebuild of
> iceweasel/38.1.1esr-1 with ~deb9u1 appended to the version number, in a
> stretch environment, failed to build from source on armhf. Build log:
> <https://people.debian.org/~jcristau/iceweasel_38.1.1est-1~deb9u1_armhf.log.txt>
> I worked around this by using ~stretch instead of ~deb9u1 for the
> subsequent 38.2.0 upload.
> 
> I suspect this might also be affecting 38.2.0esr-1~deb8u1 in the
> security archive. security.debian.org offers 38.2.0esr-1~deb8u1 for armel
> but not armhf, which supports this theory. However, security buildds don't
> publish their logs to avoid leaking details of embargoed packages, so I
> can't say for sure whether the missing build is due to a slower-than-armel
> build, this bug, or a different FTFBS.
> 
> The iceweasel packaging automatically adapts itself to be suitable for
> backports when it sees ~bpo or ~deb in the version number: in particular,
> it uses a few bundled libraries, including libvpx, instead of the system
> equivalents. If I had re-generated control.in from control, it would also
> have dropped the corresponding build-dependencies, but for a t-p-u upload
> I didn't particularly want to do that.

Could you open a separate bug for this? upstream.mk should not set
BACKPORT for deb9 at the moment.

> Instead of its upstream build system as used in src:libvpx, the bundled
> libvpx in iceweasel is built using media/libvpx/moz.build, which has
> this code:
> 
> if CONFIG['VPX_ARM_ASM']:
> ...
>     for f in SOURCES:
>         if f.endswith('.c') and 'neon' in f:
>             SOURCES[f].flags += ['-march=armv7-a', '-mthumb', '-mfloat-abi=softfp', '-mfpu=neon']

Oh man that's so wrong. Seems like '-mthumb' and '-mfloat-abi=softfp' should
be removed from there.

Mike