Bug#791537: nss: FTBFS on hppa: segmentation fault in PR_FindSymbol

[John David Anglin]

Package: nss
Version: 3.19.2-1
Severity: normal

Build fails here:
dh_strip -a --dbg-package=libnss3-dbg
umask 022; LD_LIBRARY_PATH=debian/libnss3/usr/lib/hppa-linux-gnu debian/libnss3-tools/usr/bin/shlibsign -v -i debian/libnss3/usr/lib/hppa-linux-gnu/nss/libsoftokn3.so
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Segmentation fault (core dumped)

Full log is here:
http://buildd.debian-ports.org/status/fetch.php?pkg=nss&arch=hppa&ver=2%3A3.19.2-1&stamp=1436132892

(gdb) disass
Dump of assembler code for function PR_FindSymbol:
   0xfcd89440 <+0>:	addil L%0,r19,r1
   0xfcd89444 <+4>:	stw rp,-14(sp)
   0xfcd89448 <+8>:	stw,ma r6,40(sp)
   0xfcd8944c <+12>:	copy r25,r6
   0xfcd89450 <+16>:	stw r5,-3c(sp)
   0xfcd89454 <+20>:	copy r26,r5
   0xfcd89458 <+24>:	stw r4,-38(sp)
   0xfcd8945c <+28>:	copy r19,r4
   0xfcd89460 <+32>:	stw r3,-34(sp)
   0xfcd89464 <+36>:	ldw 194(r1),r3
   0xfcd89468 <+40>:	stw r19,-20(sp)
   0xfcd8946c <+44>:	b,l 0xfcd7e150,rp
   0xfcd89470 <+48>:	ldw 0(r3),r26
   0xfcd89474 <+52>:	ldo 10(r5),r25
   0xfcd89478 <+56>:	copy r4,r19
=> 0xfcd8947c <+60>:	ldw c(r5),r26
   0xfcd89480 <+64>:	copy r6,r24

(gdb) p/x $r5
$1 = 0x0
(gdb) bt
#0  0xfcd8947c in PR_FindSymbol () from /usr/lib/hppa-linux-gnu/libnspr4.so
#1  0x00011b90 in main ()

Register r5 is a copy of register r26 which is the lib argument to
PR_FindSymbol.

This documentation for PR_FindSymbol indicates that it accepts a NULL
argument.  However, the current code from the npsr package doesn't accept
a NULL argument:

PR_FindSymbol(PRLibrary *lib, const char *raw_name)
{
    void *f = NULL;
#if defined(NEED_LEADING_UNDERSCORE)
    char *name;
#else
    const char *name;
#endif
    /*
    ** Mangle the raw symbol name in any way that is platform specific.
    */
#if defined(NEED_LEADING_UNDERSCORE)
    /* Need a leading _ */
    name = PR_smprintf("_%s", raw_name);
#elif defined(AIX)
    /*
    ** AIX with the normal linker put's a "." in front of the symbol
    ** name.  When use "svcc" and "svld" then the "." disappears. Go
    ** figure.
    */
    name = raw_name;
#else
    name = raw_name;
#endif

    PR_EnterMonitor(pr_linker_lock);
    PR_ASSERT(lib != NULL);
    f = pr_FindSymbolInLib(lib, name);

#if defined(NEED_LEADING_UNDERSCORE)
    PR_smprintf_free(name);
#endif

    PR_ExitMonitor(pr_linker_lock);
    return f;
}

Current gcc versions may remove NULL checks.

-- System Information:
Debian Release: stretch/sid
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: hppa (parisc64)

Kernel: Linux 3.18.17+ (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.utf8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)