Bug#849838: firefox: Fix broken hppa build support
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Sun Jan 1 14:29:02 UTC 2017
On 01/01/2017 03:27 PM, John David Anglin wrote:
> On 2017-01-01, at 5:45 AM, John Paul Adrian Glaubitz wrote:
>
>> I don't think it makes much sense to update the patch for the Debian package, but I can
>> update the upstream patch accordingly by adding the comment. I won't change anything
>> else though. Although I'm not even sure how important the comment is either as the
>> commit message I added explains the change in every detail.
>
> I strongly believe the code needs documentation. It greatly helps debugging.
Sure, but there is also "git blame" which will bring up the long comment you
wrote. Any, I updated the patch I sent upstream to include the comment.
>> If you look at the rest of the PA-RISC assembly code in xptcall, you'll see that all
>> mnemonics are written in upper-case, so I'm going to keep 'STW' instead of 'stw'.
>
> Doesn't matter. Uppercase is HP style.
Sure, but I just wanted the style to be consistent with the rest of the code.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz at debian.org
`. `' Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the pkg-mozilla-maintainers
mailing list