Bug#865650: firefox-esr FTBFS: tries to use system nspr but has no build dependency

[Mike Hommey]

On Fri, Jun 23, 2017 at 11:56:45PM +0900, Mike Hommey wrote:
> On Fri, Jun 23, 2017 at 04:53:19PM +0300, Adrian Bunk wrote:
> > Source: firefox-esr
> > Version: 52.2.0esr-1
> > Severity: serious
> > 
> > https://buildd.debian.org/status/package.php?p=firefox-esr&suite=sid
> > 
> > ...
> > checking for valloc in malloc.h... yes
> > checking for valloc in unistd.h... no
> > checking NSPR selection... system
> > checking for nspr-config... no
> > checking for NSPR - version >= 4.13.1... no
> > configure: error: you do not have NSPR installed or your version is older than 4.13.1.
> > ...
> 
> Whatever created the binnmu borked debian/control, but the build itself
> preprocessed it with the right flags (-DUSE_SYSTEM_NSPR="1"), but that's
> too late for the dependencies installer.
> 
> How does one get a hand on the .diff.xz?

Forget it, I figured out what's wrong, and indeed, the dependency is
missing, but that was on purpose. The bug is actually that it still
tries to build against system nspr, considering the contents, because
the distribution mentioned in debian/changelog for the binnmu is "sid",
while the scripts only know what to do for "unstable".

I also need to resync with firefox, to use the system nspr and nss.

Mike