firefox-esr 52 patches for wheezy

[Mike Hommey]

On Tue, May 23, 2017 at 11:03:54PM +0200, Emilio Pozuelo Monfort wrote:
> I don't know whether this is a bug in this version of GCC, a bug in binutils
> (maybe binutils should have been updated together with GCC, though I would be
> surprised if a lockstep update was required) or maybe it's all fine, and you
> really need -fPIC for -pie... and while we pass -fPIC when building firefox, we
> don't when running configure, which is what my change solves.

Yeah, it's the latter. It's actually weird it didn't break earlier...
and that it's not broken on unstable... Anyways, this is something that
needs to be fixed upstream, and the right patch should be the following:

diff --git a/build/autoconf/compiler-opts.m4 b/build/autoconf/compiler-opts.m4
index d2e9d4bc60c8..4f4b3b1d885a 100644
--- a/build/autoconf/compiler-opts.m4
+++ b/build/autoconf/compiler-opts.m4
@@ -262,17 +262,17 @@ fi
 MOZ_ARG_ENABLE_BOOL(pie,
 [  --enable-pie           Enable Position Independent Executables],
     MOZ_PIE=1,
     MOZ_PIE= )
 
 if test "$GNU_CC$CLANG_CC" -a -n "$MOZ_PIE"; then
     AC_MSG_CHECKING([for PIE support])
     _SAVE_LDFLAGS=$LDFLAGS
-    LDFLAGS="$LDFLAGS -pie"
+    LDFLAGS="$LDFLAGS $DSO_PIC_CFLAGS -pie"
     AC_TRY_LINK(,,AC_MSG_RESULT([yes])
                   [MOZ_PROGRAM_LDFLAGS="$MOZ_PROGRAM_LDFLAGS -pie"],
                   AC_MSG_RESULT([no])
                   AC_MSG_ERROR([--enable-pie requires PIE support from the linker.]))
     LDFLAGS=$_SAVE_LDFLAGS
 fi
 
 AC_SUBST(MOZ_PROGRAM_LDFLAGS)


Please confirm this works, and I'll have that committed upstream.

Mike