Bug#889896: firefox: 59.0~b4-1

[John Paul Adrian Glaubitz]

Source: firefox
Version: 59.0~b4-1
Severity: normal
Tags: patch
User: debian-sparc at lists.debian.org
Usertags: powerpc sparc64

Hi!

On both powerpc and sparc64, firefox FTBFS because the compiler doesn't
understand the flag -fno-lifetime-dse. This can be fixed with the following
patch which removes that compiler flag for these architectures:

--- firefox-59.0~b4/debian/rules.orig   2018-01-29 10:00:01.000000000 +0100
+++ firefox-59.0~b4/debian/rules        2018-02-08 13:56:55.173190353 +0100
@@ -112,7 +112,11 @@
 
 ifneq (,$(findstring gcc,$(CC)))
 ifeq (,$(filter 4.% 5.%,$(shell $(CC) -dumpversion)))
+ifneq (,$(filter powerpc sparc64,$(DEB_HOST_ARCH)))
+CFLAGS += -fno-schedule-insns2 -fno-delete-null-pointer-checks
+else
 CFLAGS += -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks
+endif
 ifneq (,$(filter armel armhf,$(DEB_HOST_ARCH)))
 CFLAGS += -fno-schedule-insns
 endif

The issue occurs right at the beginning when the build process is
trying to build ICU. For some reason, the configure script of ICU
prefers clang over gcc which results in this error as clang doesn't
understand -fno-lifetime-dse.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
-------------- next part --------------
--- firefox-59.0~b4/debian/rules.orig	2018-01-29 10:00:01.000000000 +0100
+++ firefox-59.0~b4/debian/rules	2018-02-08 13:56:55.173190353 +0100
@@ -112,7 +112,11 @@
 
 ifneq (,$(findstring gcc,$(CC)))
 ifeq (,$(filter 4.% 5.%,$(shell $(CC) -dumpversion)))
+ifneq (,$(filter powerpc sparc64,$(DEB_HOST_ARCH)))
+CFLAGS += -fno-schedule-insns2 -fno-delete-null-pointer-checks
+else
 CFLAGS += -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks
+endif
 ifneq (,$(filter armel armhf,$(DEB_HOST_ARCH)))
 CFLAGS += -fno-schedule-insns
 endif