Bug#888634: firefox: FTBFS on armhf: spurious -mfloat-abi=softfp, no <gnu/stubs-soft.h>

[Aaron M. Ucko]

Source: firefox
Version: 58.0-1
Severity: serious
Tags: upstream
Justification: fails to build from source (but built successfully in the past)
User: debian-arm at lists.debian.org
Usertags: armhf
Control: forwarded -1 https://bugzilla.mozilla.org/show_bug.cgi?id=1433725

Builds of firefox for armhf have been failing lately, per the below
excerpts from https://buildd.debian.org/status/fetch.php?pkg=firefox&arch=armhf&ver=58.0-1&stamp=1516880296&raw=0:

  usr/bin/g++ -std=gnu++11 -o Unified_cpp_utility0.o -c -I/<<PKGBUILDDIR>>/build-browser/dist/system_wrappers -include /<<PKGBUILDDIR>>/config/gcc_hidden.h -DNDEBUG -DTRIMMED=1 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DWEBRTC_RESTRICT_LOGGING -DWEBRTC_MOZILLA_BUILD -DWEBRTC_VOE_EXTERNAL_REC_AND_PLAYOUT -DEXPAT_RELATIVE_PATH -DWEBRTC_ARCH_ARM -DWEBRTC_ARCH_ARM_V7 -DWEBRTC_BUILD_NEON_LIBS -DWEBRTC_HAS_NEON -DWEBRTC_POSIX -DWEBRTC_LINUX -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE -DWEBRTC_BUILD_LIBEVENT -D__STDC_FORMAT_MACROS -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/<<PKGBUILDDIR>>/media/webrtc/trunk/webrtc/modules/video_coding/utility -I/<<PKGBUILDDIR>>/build-browser/media/webrtc/trunk/webrtc/modules/video_coding/utility/video_coding_utility_video_coding_utility -I/<<PKGBUILDDIR>>/media/webrtc/trunk -I/<<PKGBUILDDIR>>/media/webrtc/trunk/webrtc/common_video/include -I/<<PKGBUILDDIR>>/media/webrtc/trunk/webrtc/common_video/libyuv/include -I/<<PKGBUILDDIR>>/build-browser/ipc/ipdl/_ipdlheaders -I/<<PKGBUILDDIR>>/ipc/chromium/src -I/<<PKGBUILDDIR>>/ipc/glue -I/<<PKGBUILDDIR>>/build-browser/dist/include -fPIC -DMOZILLA_CLIENT -include /<<PKGBUILDDIR>>/build-browser/mozilla-config.h -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wc++1z-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -fstack-protector-strong -Wformat -Werror=format-security -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks -fno-schedule-insns -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fomit-frame-pointer -mfloat-abi=softfp -mfpu=neon  -MD -MP -MF .deps/Unified_cpp_utility0.o.pp   /<<PKGBUILDDIR>>/build-browser/media/webrtc/trunk/webrtc/modules/video_coding/utility/video_coding_utility_video_coding_utility/Unified_cpp_utility0.cpp
  In file included from /usr/include/features.h:443:0,
  [...]
                   from /<<PKGBUILDDIR>>/build-browser/media/webrtc/trunk/webrtc/modules/video_coding/utility/video_coding_utility_video_coding_utility/Unified_cpp_utility0.cpp:2:
  /usr/include/arm-linux-gnueabihf/gnu/stubs.h:7:11: fatal error: gnu/stubs-soft.h: No such file or directory

Note the explicit use of -mfloat-api=softp, which is inappropriate
here.  Per your general instructions, I have also reported this bug
upstream, as https://bugzilla.mozilla.org/show_bug.cgi?id=1433725 (and
proceeded to mark it as forwarded).

Could you please take a look?

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@monk.mit.edu