[SCM] mplayer packaging branch, karmic, updated. debian/1.0.rc3+svn20090426-1ubuntu3-1-gd2ac685

Reinhard Tartler siretart at tauware.de
Tue Jun 23 10:51:24 UTC 2009


A Mennucc <debdev at tonelli.sns.it> writes:

> On Wed, Jun 17, 2009 at 02:29:26PM +0000, siretart at users.alioth.debian.org wrote:
>> The following commit has been merged in the karmic branch:
>> commit d2ac685e61922ea7e53686568b6c887a0ac6eaaf
>> Author: Reinhard Tartler <siretart at tauware.de>
>> Date:   Wed Jun 17 16:29:03 2009 +0200
>> 
>>     remove 22disable-xscreensaver.patch
>>     
>>     Faking input keyboard or mouse events is clearly the wrong approach to
>>     the problem. Actually, it is even potentially dangerous, because it can
>>     cause unexpected sideeffects on the users desktop (closing windows,
>>     sending messages, etc). Moreover, this doesn't seem to work with
>>     gnome-screensaver after all.
>
> I beg to disagree.
>
> When I created that patch, I tested it a lot, and it never proved to be dangerous.
> Do you have evidence that it *IS* dangerous ? Did you test it?
> Do you know how the patch works?
>
> Also, the fact that it does not work with gnome-screensaver does not
> mean that the patch should be killed, for at least two good reasons:
> 1) there are a lot of other screensavers around, and there is KDE, etc etc;
> 2) there is AFAIK no support for gnome-screensaver in mplayer, and
>  removing this patch does not fix the problem. That is,
>  the fact that this patch does not work with gnome-screensaver
>  does not imply its removal in any way that I can think of.

I have discussed this patch with upstream on their IRC channel. They
have assured me that the screensaver code has been rewritten and to
upstream's knowledge, the rewritten screensaver code in the rc3 release
works with all popular screensavers but gnome-screensaver.

Moreover the patch works by faking mouse movements. Depending on what
screensaver is being in use, this can e.g. move focus, activate other
windows or worse. The general opinion of upstream is to generally avoid
faking input events and use the facilities that are provided by
screensaver implementations instead. I tend to agree to that argument.

May I suggest that you try again to "upstream" that patch? The patch as
it stands does not indicate that upstream has seen it yet at all. When I
referred to it, I have been suggested to just drop it, which I did for
ubuntu.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4



More information about the pkg-multimedia-commits mailing list