[SCM] swh-plugins/master: Fix buffer overrun that causes explosions on little endian 64bit platforms.

alessio at users.alioth.debian.org alessio at users.alioth.debian.org
Thu Dec 27 16:45:45 UTC 2012


The following commit has been merged in the master branch:
commit f8653b4c8e835391074d889ce46bba97de9080e6
Author: Alessio Treglia <alessio at debian.org>
Date:   Thu Dec 27 16:45:21 2012 +0000

    Fix buffer overrun that causes explosions on little endian 64bit platforms.
    
    Closes:# 629263

diff --git a/debian/patches/05-mbeq_crash_fix.diff b/debian/patches/05-mbeq_crash_fix.diff
new file mode 100644
index 0000000..5d5c7e6
--- /dev/null
+++ b/debian/patches/05-mbeq_crash_fix.diff
@@ -0,0 +1,47 @@
+Description: Fix buffer overrun that causes explosions on little
+ endian 64bit platforms.
+Origin: https://github.com/swh/ladspa/commit/3b61bb945c5e09ac
+Applied-Upstream: yes
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=629263
+---
+ mbeq_1197.c    |    3 ++-
+ mbeq_1197.so.c |    3 ++-
+ mbeq_1197.xml  |    3 ++-
+ 3 files changed, 6 insertions(+), 3 deletions(-)
+
+--- swh-plugins.orig/mbeq_1197.c
++++ swh-plugins/mbeq_1197.c
+@@ -457,7 +457,8 @@ static void runMbeq(LADSPA_Handle instan
+ 	#endif
+ 	
+ 	                // Multiply the bins magnitudes by the coeficients
+-	                for (i = 0; i < FFT_LENGTH/2; i++) {
++	                comp[0] *= coefs[0];
++	                for (i = 1; i < FFT_LENGTH/2; i++) {
+ 	                        comp[i] *= coefs[i];
+ 	                        comp[FFT_LENGTH-i] *= coefs[i];
+ 	                }
+--- swh-plugins.orig/mbeq_1197.so.c
++++ swh-plugins/mbeq_1197.so.c
+@@ -446,7 +446,8 @@ static void runMbeq(LADSPA_Handle instan
+ 	#endif
+ 	
+ 	                // Multiply the bins magnitudes by the coeficients
+-	                for (i = 0; i < FFT_LENGTH/2; i++) {
++	                comp[0] *= coefs[0];
++	                for (i = 1; i < FFT_LENGTH/2; i++) {
+ 	                        comp[i] *= coefs[i];
+ 	                        comp[FFT_LENGTH-i] *= coefs[i];
+ 	                }
+--- swh-plugins.orig/mbeq_1197.xml
++++ swh-plugins/mbeq_1197.xml
+@@ -171,7 +171,8 @@ for (pos = 0; pos < sample_count; pos++)
+ #endif
+ 
+ 		// Multiply the bins magnitudes by the coeficients
+-		for (i = 0; i < FFT_LENGTH/2; i++) {
++		comp[0] *= coefs[0];
++		for (i = 1; i < FFT_LENGTH/2; i++) {
+ 			comp[i] *= coefs[i];
+ 			comp[FFT_LENGTH-i] *= coefs[i];
+ 		}
diff --git a/debian/patches/series b/debian/patches/series
index 835cb68..6c50447 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@
 02-fix-spelling-add-de.po.diff
 03-uptodate-ltmain.diff
 04-nosetlocale.diff
+05-mbeq_crash_fix.diff

-- 
swh-plugins packaging



More information about the pkg-multimedia-commits mailing list