[SCM] horgand/master: Prevent SIGSEGV by fixing a buffer overflow, it was tryng to strcpy() of an 11 char string (+ '\0') into a 10 char fixed array.

alessio at users.alioth.debian.org alessio at users.alioth.debian.org
Wed Jan 2 14:28:01 UTC 2013


The following commit has been merged in the master branch:
commit ed75efd94b1c34c7255fdb40a06de9c1360385f0
Author: Alessio Treglia <alessio at debian.org>
Date:   Wed Jan 2 14:05:04 2013 +0000

    Prevent SIGSEGV by fixing a buffer overflow, it was tryng to
    strcpy() of an 11 char string (+ '\0') into a 10 char fixed array.
    
    Closes: #695467
    LP: #891939

diff --git a/debian/patches/03-buffer_overflow.patch b/debian/patches/03-buffer_overflow.patch
new file mode 100644
index 0000000..655727f
--- /dev/null
+++ b/debian/patches/03-buffer_overflow.patch
@@ -0,0 +1,20 @@
+Description: Buffer was too short for chord name
+Author: dave at treblig.org
+Bug-Ubuntu: https://launchpad.net/bugs/891939
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695467
+Forwarded: no
+---
+ src/Holrgan.h |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- horgand.orig/src/Holrgan.h
++++ horgand/src/Holrgan.h
+@@ -398,7 +398,7 @@ struct Ch3
+ struct Ch4
+ 
+ {
+-  char Nom[10];
++  char Nom[12];
+   int type;
+   int fund;
+   int dist1;
diff --git a/debian/patches/series b/debian/patches/series
index def9ac0..47a5fd8 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 01-fix_manpage.patch
 02-binutils_gold.patch
+03-buffer_overflow.patch

-- 
horgand packaging



More information about the pkg-multimedia-commits mailing list