[SCM] libav/experimental: Attempt to better explain how to split patches into individual self-contained pieces.

siretart at users.alioth.debian.org siretart at users.alioth.debian.org
Sun Jun 30 16:05:31 UTC 2013


The following commit has been merged in the experimental branch:
commit e1669c5ebe775c81d4b5e6abf8d03a9e86d1c5a8
Author: Diego Biurrun <diego at biurrun.de>
Date:   Mon Aug 13 22:15:48 2007 +0000

    Attempt to better explain how to split patches into individual
    self-contained pieces.
    
    Originally committed as revision 10108 to svn://svn.ffmpeg.org/ffmpeg/trunk

diff --git a/doc/ffmpeg-doc.texi b/doc/ffmpeg-doc.texi
index 53f36a1..fafe3cb 100644
--- a/doc/ffmpeg-doc.texi
+++ b/doc/ffmpeg-doc.texi
@@ -1673,9 +1673,12 @@ First, (@pxref{Coding Rules}) above if you did not yet.
 When you submit your patch, try to send a unified diff (diff '-up'
 option). We cannot read other diffs :-)
 
-Also please do not submit patches which contain several unrelated changes.
-Split them into individual self-contained patches; this makes reviewing
-them much easier.
+Also please do not submit a patch which contains several unrelated changes.
+Split it into separate, self-contained pieces. This does not mean splitting
+file by file. Instead, make the patch as small as possible while still
+keeping it as a logical unit that contains an individual change, even
+if it spans multiple files. This makes reviewing your patches much easier
+for us and greatly increases your chances of getting your patch applied.
 
 Run the regression tests before submitting a patch so that you can
 verify that there are no big problems.

-- 
Libav/FFmpeg packaging



More information about the pkg-multimedia-commits mailing list