[SCM] libav/experimental: 10000l, revert r14254 Log: The funny memcpyin svq3 generally has src & dst overlapping, so it should at least be a memmove(). I was tired, they do not overlap.

siretart at users.alioth.debian.org siretart at users.alioth.debian.org
Sun Jun 30 16:25:28 UTC 2013


The following commit has been merged in the experimental branch:
commit 9dff86c672f06c3b342bbe6d89c52937900d23c7
Author: Michael Niedermayer <michaelni at gmx.at>
Date:   Wed Jul 16 17:54:57 2008 +0000

    10000l, revert
    	r14254
    	Log:
    	The funny memcpyin svq3 generally has src & dst overlapping, so it
    	should at least be a memmove().
    I was tired, they do not overlap.
    
    Originally committed as revision 14259 to svn://svn.ffmpeg.org/ffmpeg/trunk

diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
index a5868e1..67fa317 100644
--- a/libavcodec/svq3.c
+++ b/libavcodec/svq3.c
@@ -704,7 +704,7 @@ static int svq3_decode_slice_header (H264Context *h) {
     skip_bits(&s->gb, 8);
 
     if (length > 0) {
-      memmove ((uint8_t *) &s->gb.buffer[get_bits_count(&s->gb) >> 3],
+      memcpy ((uint8_t *) &s->gb.buffer[get_bits_count(&s->gb) >> 3],
              &s->gb.buffer[s->gb.size_in_bits >> 3], (length - 1));
     }
   }

-- 
Libav/FFmpeg packaging



More information about the pkg-multimedia-commits mailing list