[SCM] libav/experimental: Fix for issue #829 ("ffvorbis outputs crackling sound, libvorbis plays fine")
siretart at users.alioth.debian.org
siretart at users.alioth.debian.org
Sun Jun 30 16:45:47 UTC 2013
The following commit has been merged in the experimental branch:
commit 460c0abfbb6390533a8a04e661971ff0ad4c6cbd
Author: Siarhei Siamashka <siarhei.siamashka at gmail.com>
Date: Thu May 14 06:38:49 2009 +0000
Fix for issue #829 ("ffvorbis outputs crackling sound, libvorbis plays fine")
This was off-by-one bug which affects floor0 encoded files. Tracked down
by valgrind (was reported as the use of uninitialized memory).
With this patch applied, tiny_psnr now reports the following when ffvorbis
is compared to libvorbis-1.0beta4 output for 'lsp-test.ogg' sample:
stddev: 0.76 PSNR: 98.69 bytes: 3498380/ 3498452
Output from libvorbis-1.2 is substantially different:
stddev: 132.57 PSNR: 53.87 bytes: 3498424/ 3498496
Originally committed as revision 18821 to svn://svn.ffmpeg.org/ffmpeg/trunk
diff --git a/libavcodec/vorbis_dec.c b/libavcodec/vorbis_dec.c
index 12a9fed..b304e7b 100644
--- a/libavcodec/vorbis_dec.c
+++ b/libavcodec/vorbis_dec.c
@@ -1054,7 +1054,7 @@ static uint_fast8_t vorbis_floor0_decode(vorbis_context *vc,
float two_cos_w=2.0f*cos(wstep*iter_cond); // needed all times
/* similar part for the q and p products */
- for(j=0;j<order;j+=2) {
+ for(j=0;j+1<order;j+=2) {
q *= lsp[j] -two_cos_w;
p *= lsp[j+1]-two_cos_w;
}
--
Libav/FFmpeg packaging
More information about the pkg-multimedia-commits
mailing list