[SCM] libav/experimental: Only consider -1 as an error return value for open(). This is: - what Posix says (-1 on error, >=0 on success) - fixing a bug on winCE (<0 sometimes)

siretart at users.alioth.debian.org siretart at users.alioth.debian.org
Sun Jun 30 16:49:22 UTC 2013


The following commit has been merged in the experimental branch:
commit fbf7e805b0331c8329ad46ba7d40962d8b3d1a0c
Author: Martin Storsjö <martin at martin.st>
Date:   Mon Jul 27 12:36:22 2009 +0000

    Only consider -1 as an error return value for open().
    This is:
     - what Posix says (-1 on error, >=0 on success)
     - fixing a bug on winCE (<0 sometimes)
    
    Patch by Martin Storsjö: martin martin st
    
    Originally committed as revision 19513 to svn://svn.ffmpeg.org/ffmpeg/trunk

diff --git a/libavformat/file.c b/libavformat/file.c
index da0ce15..d2cb530 100644
--- a/libavformat/file.c
+++ b/libavformat/file.c
@@ -51,7 +51,7 @@ static int file_open(URLContext *h, const char *filename, int flags)
     access |= O_BINARY;
 #endif
     fd = open(filename, access, 0666);
-    if (fd < 0)
+    if (fd == -1)
         return AVERROR(ENOENT);
     h->priv_data = (void *) (intptr_t) fd;
     return 0;

-- 
Libav/FFmpeg packaging



More information about the pkg-multimedia-commits mailing list