[SCM] libav/experimental: Take into account real number of colours when reading BMP palette. This fixes issue 1408
siretart at users.alioth.debian.org
siretart at users.alioth.debian.org
Sun Jun 30 16:51:49 UTC 2013
The following commit has been merged in the experimental branch:
commit 22da339f5ddf4a5880050e9dac60ef7c4592e443
Author: Kostya Shishkov <kostya.shishkov at gmail.com>
Date: Thu Sep 24 05:24:46 2009 +0000
Take into account real number of colours when reading BMP palette.
This fixes issue 1408
Originally committed as revision 20007 to svn://svn.ffmpeg.org/ffmpeg/trunk
diff --git a/libavcodec/bmp.c b/libavcodec/bmp.c
index cadaeee..8a73fb7 100644
--- a/libavcodec/bmp.c
+++ b/libavcodec/bmp.c
@@ -231,12 +231,23 @@ static int bmp_decode_frame(AVCodecContext *avctx,
}
if(avctx->pix_fmt == PIX_FMT_PAL8){
+ int colors = 1 << depth;
+ if(ihsize >= 36){
+ int t;
+ buf = buf0 + 46;
+ t = bytestream_get_le32(&buf);
+ if(t < 0 || t > (1 << depth)){
+ av_log(avctx, AV_LOG_ERROR, "Incorrect number of colors - %X for bitdepth %d\n", t, depth);
+ }else if(t){
+ colors = t;
+ }
+ }
buf = buf0 + 14 + ihsize; //palette location
- if((hsize-ihsize-14)>>depth < 4){ // OS/2 bitmap, 3 bytes per palette entry
- for(i = 0; i < (1 << depth); i++)
+ if((hsize-ihsize-14) < (colors << 2)){ // OS/2 bitmap, 3 bytes per palette entry
+ for(i = 0; i < colors; i++)
((uint32_t*)p->data[1])[i] = bytestream_get_le24(&buf);
}else{
- for(i = 0; i < (1 << depth); i++)
+ for(i = 0; i < colors; i++)
((uint32_t*)p->data[1])[i] = bytestream_get_le32(&buf);
}
buf = buf0 + hsize;
--
Libav/FFmpeg packaging
More information about the pkg-multimedia-commits
mailing list