[SCM] libav/experimental: Replace ` ` syntax by $( ) in regression test shell scripts. The latter syntax variant is more readable and easier to nest.

siretart at users.alioth.debian.org siretart at users.alioth.debian.org
Sun Jun 30 16:56:23 UTC 2013


The following commit has been merged in the experimental branch:
commit 3d1470649c91aa9d325b94aef54fc15b8185356d
Author: Diego Biurrun <diego at biurrun.de>
Date:   Sat Dec 26 11:24:04 2009 +0000

    Replace ` ` syntax by $( ) in regression test shell scripts.
    The latter syntax variant is more readable and easier to nest.
    
    Originally committed as revision 20924 to svn://svn.ffmpeg.org/ffmpeg/trunk

diff --git a/tests/ffserver-regression.sh b/tests/ffserver-regression.sh
index 711e169..592787d 100755
--- a/tests/ffserver-regression.sh
+++ b/tests/ffserver-regression.sh
@@ -3,7 +3,7 @@
 #perl -e 'chomp($wd = `pwd`); print map { s!tests/data/!!; "<Stream $_>\nFile $wd/tests/data/$_\n</Stream>\n\n" } @ARGV' tests/data/a* >> tests/data/ffserver.conf
 #perl -e 'chomp($wd = `pwd`); print map { s!tests/data/!!; "<Stream $_.asf>\nFile $wd/tests/data/$_\n</Stream>\n\n" } @ARGV' tests/data/a* >> tests/data/ffserver.conf
 
-FILES=`sed -n 's/^[^#]*<Stream \(.*\)>.*/\1/p' $2 | grep -v html`
+FILES=$(sed -n 's/^[^#]*<Stream \(.*\)>.*/\1/p' $2 | grep -v html)
 
 rm -f tests/feed1.ffm
 ./ffserver -d -f "$2" 2> /dev/null &
@@ -15,7 +15,7 @@ sleep 2
     rm -f ff-*;
     WGET_OPTIONS="--user-agent=NSPlayer -q --proxy=off -e verbose=off -e server_response=off"
     for file in $FILES; do
-        if [ `expr $file : "a-*"` != 0 ]; then
+        if [ $(expr $file : "a-*") != 0 ]; then
             wget $WGET_OPTIONS -O - http://localhost:9999/$file > ff-$file
         else
             wget $WGET_OPTIONS -O - http://localhost:9999/$file?date=19700101T000000Z | dd bs=1 count=20000 > ff-$file 2>/dev/null
diff --git a/tests/regression-funcs.sh b/tests/regression-funcs.sh
index 388a8ff..6c1191a 100755
--- a/tests/regression-funcs.sh
+++ b/tests/regression-funcs.sh
@@ -33,9 +33,9 @@ pcm_ref="$datadir/$test_ref.ref.wav"
 crcfile="$datadir/$this.crc"
 target_crcfile="$target_datadir/$this.crc"
 
-if [ X"`echo | md5sum 2> /dev/null`" != X ]; then
+if [ X"$(echo | md5sum 2> /dev/null)" != X ]; then
     do_md5sum() { md5sum -b $1; }
-elif [ X"`echo | md5 2> /dev/null`" != X ]; then
+elif [ X"$(echo | md5 2> /dev/null)" != X ]; then
     do_md5sum() { md5 $1 | sed 's#MD5 (\(.*\)) = \(.*\)#\2 *\1#'; }
 elif [ -x /sbin/md5 ]; then
     do_md5sum() { /sbin/md5 -r $1 | sed 's# \**\./# *./#'; }
@@ -60,8 +60,8 @@ do_ffmpeg()
     else
         wc -c $f >> $logfile
     fi
-    expr "`cat $bench`" : '.*utime=\(.*s\)' > $bench2
-    echo `cat $bench2` $f >> $benchfile
+    expr "$(cat $bench)" : '.*utime=\(.*s\)' > $bench2
+    echo $(cat $bench2) $f >> $benchfile
 }
 
 do_ffmpeg_nomd5()
@@ -78,8 +78,8 @@ do_ffmpeg_nomd5()
     else
         wc -c $f >> $logfile
     fi
-    expr "`cat $bench`" : '.*utime=\(.*s\)' > $bench2
-    echo `cat $bench2` $f >> $benchfile
+    expr "$(cat $bench)" : '.*utime=\(.*s\)' > $bench2
+    echo $(cat $bench2) $f >> $benchfile
 }
 
 do_ffmpeg_crc()
@@ -88,7 +88,7 @@ do_ffmpeg_crc()
     shift
     echo $ffmpeg $FFMPEG_OPTS $* -f crc "$target_crcfile"
     $ffmpeg $FFMPEG_OPTS $* -f crc "$target_crcfile"
-    echo "$f `cat $crcfile`" >> $logfile
+    echo "$f $(cat $crcfile)" >> $logfile
     rm -f "$crcfile"
 }
 
@@ -98,8 +98,8 @@ do_ffmpeg_nocheck()
     shift
     echo $ffmpeg $FFMPEG_OPTS $*
     $ffmpeg $FFMPEG_OPTS -benchmark $* > $bench
-    expr "`cat $bench`" : '.*utime=\(.*s\)' > $bench2
-    echo `cat $bench2` $f >> $benchfile
+    expr "$(cat $bench)" : '.*utime=\(.*s\)' > $bench2
+    echo $(cat $bench2) $f >> $benchfile
 }
 
 do_video_decoding()
diff --git a/tests/seek-regression.sh b/tests/seek-regression.sh
index 3074d70..177bc68 100755
--- a/tests/seek-regression.sh
+++ b/tests/seek-regression.sh
@@ -11,7 +11,7 @@ datadir="tests/data"
 logfile="$datadir/seek.regression"
 reffile="$1"
 
-list=`grep '^tests/data/[ab]-' "$reffile"`
+list=$(grep '^tests/data/[ab]-' "$reffile")
 rm -f $logfile
 for i in $list ; do
     echo ---------------- >> $logfile

-- 
Libav/FFmpeg packaging



More information about the pkg-multimedia-commits mailing list