[SCM] calf/master: Fix a recent heap corruption bug in DSSI wrapper that affected Organ.

js at users.alioth.debian.org js at users.alioth.debian.org
Tue May 7 15:40:05 UTC 2013


The following commit has been merged in the master branch:
commit 879709a7a2d934428d095ecdfb5caaa4d285ab30
Author: Krzysztof Foltman <wdev at foltman.com>
Date:   Sun Apr 11 00:19:54 2010 +0100

    Fix a recent heap corruption bug in DSSI wrapper that affected Organ.
    
    The code allocated space for all inputs, outputs and float ports, then
    wrote all ports (even string ones). This caused heap corruption and
    crashes.

diff --git a/src/plugin.cpp b/src/plugin.cpp
index e37d6e7..d2e899a 100644
--- a/src/plugin.cpp
+++ b/src/plugin.cpp
@@ -321,7 +321,7 @@ void ladspa_plugin_metadata_set::prepare(const plugin_metadata_iface *md, LADSPA
         prh.HintDescriptor = 0;
         ((const char **)descriptor.PortNames)[i] = md->get_port_names()[i];
     }
-    for (; i < input_count + output_count + param_count; i++)
+    for (; i < input_count + output_count + real_param_count; i++)
     {
         LADSPA_PortRangeHint &prh = ((LADSPA_PortRangeHint *)descriptor.PortRangeHints)[i];
         const parameter_properties &pp = *md->get_param_props(i - input_count - output_count);

-- 
calf audio plugins packaging



More information about the pkg-multimedia-commits mailing list