[SCM] hydrogen-drumkits/master: use `find -exec` rather than for loops

umlaeute at users.alioth.debian.org umlaeute at users.alioth.debian.org
Tue Sep 22 08:59:50 UTC 2015


The following commit has been merged in the master branch:
commit 2de96fba3391a52da52524eb4dc9a73848b5a0ef
Author: IOhannes m zmölnig <zmoelnig at umlautQ.umlaeute.mur.at>
Date:   Tue Sep 22 10:59:06 2015 +0200

    use `find -exec` rather than for loops
    
    for loops don't behave well if a pattern does not exist.

diff --git a/debian/rules b/debian/rules
index 156aa52..f345990 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,22 +10,18 @@ override_dh_auto_build:
 override_dh_auto_install:
 	mkdir -p $(KITS_DIR)
 	mkdir -p tmp
-	@for i in drumkits/*.tar.gz; do \
-		echo "Extracting kit $$i"; \
-		tar zxf $$i -C tmp; \
-	done
-	@for i in drumkits/*.zip; do \
-		echo "Extracting kit $$i"; \
-		unzip $$i -d tmp > /dev/null; \
-	done
-	@for i in drumkits/*.h2drumkit; do \
-		echo "Extracting kit $$i"; \
-		cp $$i tmp; \
-	done
-	@for i in $$(find tmp/ -name "*.h2drumkit"); do \
-		echo "Installing kit $$i"; \
-		tar xfz $$i -C $(KITS_DIR); \
-	done
+	find drumkits/ \
+		-name "*.tar.*" -or -name "*.tgz" \
+		-exec tar xf '{}' -C tmp ';'
+	find drumkits/ \
+		-name "*.zip" \
+		-exec unzip '{}' -d tmp > /dev/null ';'
+	find drumkits/ \
+		-name "*.h2drumkit" \
+		-exec cp '{}' tmp ';'
+	find tmp/ -name "*.h2drumkit" \
+		-exec echo installing drumkit '{}' ';' \
+		-exec tar xf '{}' -C $(KITS_DIR) ';'
 
 get-orig-source:
 	chmod a+x debian/get-orig-source

-- 
hydrogen-drumkits packaging



More information about the pkg-multimedia-commits mailing list