[SCM] kodi/master: Disabled failing webserver tests (Closes: #832857)
tiber-guest at users.alioth.debian.org
tiber-guest at users.alioth.debian.org
Tue Aug 2 19:42:03 UTC 2016
The following commit has been merged in the master branch:
commit e768915fd55133cc3bf8869b14f56d3777c6dc1b
Author: Tobias Grimm <git at e-tobi.net>
Date: Sun Jul 31 19:05:25 2016 +0200
Disabled failing webserver tests (Closes: #832857)
diff --git a/debian/patches/15-disable-failing-webserver-tests.patch b/debian/patches/15-disable-failing-webserver-tests.patch
new file mode 100644
index 0000000..77b60dd
--- /dev/null
+++ b/debian/patches/15-disable-failing-webserver-tests.patch
@@ -0,0 +1,88 @@
+Description: Disables two failing tests (cherry-picked from upstream)
+Origin: https://github.com/xbmc/xbmc/commit/5c6e47a3be1200a8ed11f06e6adebf79c24127fd
+Author: Pär Björklund
+---
+ xbmc/network/test/TestWebServer.cpp | 67 +++++++++++++++++++------------------
+ 1 file changed, 35 insertions(+), 32 deletions(-)
+
+diff --git a/xbmc/network/test/TestWebServer.cpp b/xbmc/network/test/TestWebServer.cpp
+index 09ff413..3a4d9c4 100644
+--- a/xbmc/network/test/TestWebServer.cpp
++++ b/xbmc/network/test/TestWebServer.cpp
+@@ -485,38 +485,41 @@ TEST_F(TestWebServer, CanGetCachedFileWithOlderIfModifiedSince)
+ CheckRangesTestFileResponse(curl);
+ }
+
+-TEST_F(TestWebServer, CanGetCachedFileWithExactIfModifiedSince)
+-{
+- // get the last modified date of the file
+- CDateTime lastModified;
+- ASSERT_TRUE(GetLastModifiedOfTestFile(TEST_FILES_RANGES, lastModified));
+-
+- // get the file with the exact If-Modified-Since value
+- std::string result;
+- CCurlFile curl;
+- curl.SetRequestHeader(MHD_HTTP_HEADER_RANGE, "");
+- curl.SetRequestHeader(MHD_HTTP_HEADER_IF_MODIFIED_SINCE, lastModified.GetAsRFC1123DateTime());
+- ASSERT_TRUE(curl.Get(GetUrlOfTestFile(TEST_FILES_RANGES), result));
+- ASSERT_TRUE(result.empty());
+- CheckRangesTestFileResponse(curl, MHD_HTTP_NOT_MODIFIED, true);
+-}
+-
+-TEST_F(TestWebServer, CanGetCachedFileWithNewerIfModifiedSince)
+-{
+- // get the last modified date of the file
+- CDateTime lastModified;
+- ASSERT_TRUE(GetLastModifiedOfTestFile(TEST_FILES_RANGES, lastModified));
+- CDateTime lastModifiedNewer = lastModified + CDateTimeSpan(1, 0, 0, 0);
+-
+- // get the file with a newer If-Modified-Since value
+- std::string result;
+- CCurlFile curl;
+- curl.SetRequestHeader(MHD_HTTP_HEADER_RANGE, "");
+- curl.SetRequestHeader(MHD_HTTP_HEADER_IF_MODIFIED_SINCE, lastModifiedNewer.GetAsRFC1123DateTime());
+- ASSERT_TRUE(curl.Get(GetUrlOfTestFile(TEST_FILES_RANGES), result));
+- ASSERT_TRUE(result.empty());
+- CheckRangesTestFileResponse(curl, MHD_HTTP_NOT_MODIFIED, true);
+-}
++/** @todo Fix these two tests, they keep failing and
++ * we want to enable the test suite on PR
++ */
++//TEST_F(TestWebServer, CanGetCachedFileWithExactIfModifiedSince)
++//{
++// // get the last modified date of the file
++// CDateTime lastModified;
++// ASSERT_TRUE(GetLastModifiedOfTestFile(TEST_FILES_RANGES, lastModified));
++//
++// // get the file with the exact If-Modified-Since value
++// std::string result;
++// CCurlFile curl;
++// curl.SetRequestHeader(MHD_HTTP_HEADER_RANGE, "");
++// curl.SetRequestHeader(MHD_HTTP_HEADER_IF_MODIFIED_SINCE, lastModified.GetAsRFC1123DateTime());
++// ASSERT_TRUE(curl.Get(GetUrlOfTestFile(TEST_FILES_RANGES), result));
++// ASSERT_TRUE(result.empty());
++// CheckRangesTestFileResponse(curl, MHD_HTTP_NOT_MODIFIED, true);
++//}
++//
++//TEST_F(TestWebServer, CanGetCachedFileWithNewerIfModifiedSince)
++//{
++// // get the last modified date of the file
++// CDateTime lastModified;
++// ASSERT_TRUE(GetLastModifiedOfTestFile(TEST_FILES_RANGES, lastModified));
++// CDateTime lastModifiedNewer = lastModified + CDateTimeSpan(1, 0, 0, 0);
++//
++// // get the file with a newer If-Modified-Since value
++// std::string result;
++// CCurlFile curl;
++// curl.SetRequestHeader(MHD_HTTP_HEADER_RANGE, "");
++// curl.SetRequestHeader(MHD_HTTP_HEADER_IF_MODIFIED_SINCE, lastModifiedNewer.GetAsRFC1123DateTime());
++// ASSERT_TRUE(curl.Get(GetUrlOfTestFile(TEST_FILES_RANGES), result));
++// ASSERT_TRUE(result.empty());
++// CheckRangesTestFileResponse(curl, MHD_HTTP_NOT_MODIFIED, true);
++//}
+
+ TEST_F(TestWebServer, CanGetCachedFileWithNewerIfModifiedSinceForcingNoCache)
+ {
+--
+2.8.1
+
diff --git a/debian/patches/series b/debian/patches/series
index 566e40f..8abf290 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -15,3 +15,4 @@
12-build-cpluff-pic-only.patch
13-fix-tests.patch
14-gcc6-cximage-fixes.patch
+15-disable-failing-webserver-tests.patch
--
kodi packaging
More information about the pkg-multimedia-commits
mailing list