[Pkg-mwavem-devel] Bug#476761: Bug#476761: mwavem: bashism in /bin/sh script

[tony mancill]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Raphael,

Thank you for the bug report.  I see that PIPESTATUS[] is definitely a
bashism, but I am confused as to why checkbashism reports "kill -9" as a
possible bashism.  Is it because kill is a built-in for bash, but not for
dash (and the procps executable is used instead)?

Thanks,
Tony

Raphael Geissert wrote:
> Package: mwavem
> Severity: important
> Version: 2.0-2
> User: debian-release at lists.debian.org
> Usertags: goal-dash
> 
> Hello maintainer,
> 
> While performing an archive wide checkbashisms (from the 'devscripts' package) 
> check I've found your package containing several /bin/sh scripts making 
> use of a bashism.
> 
> checkbashisms' output:
>> possible bashism in ./usr/sbin/mwavemd line 104 (bash arrays,
>> ${name[0|*|@]}):
>> exitstatus=${PIPESTATUS[1]} 
>> possible bashism in ./etc/init.d/mwavem line 206 (kill -[0-9] or -[A-Z]):
>>                                 kill -9 "$(pidof $DAEMONPATHNAME)"
>>> /dev/null 2>&1 possible bashism in ./etc/init.d/mwavem line 218 (kill
>> -[0-9] or -[A-Z]):
>> kill -9 "$(pidof $MWAVEMANAGERPATHNAME)" >/dev/null 2>&1 
>>  # Just to make sure
> 
> Not using bash (or a Debian Policy conformant shell interpreter which does 
> provide such an extra feature) as /bin/sh is likely to lead to errors or 
> unexpected behaviours.
> Please be aware that although bash is currently the default /bin/sh there's a 
> release goal for Lenny to make dash the default /bin/sh[1].
> 
> If you want more information about dash as /bin/sh, you can read:
> http://lists.debian.org/debian-release/2008/01/msg00189.html
> 
> For more information please refer to the Debian Policy section 10.4 supporting 
> this argument at:
> http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts
> 
> Hints about how to fix bashisms:
> Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
> If not already fixed you can read:
> https://wiki.ubuntu.com/DashAsBinSh
> 
> [1]http://release.debian.org/lenny/goals.txt
> 
> Thank you,

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIDBkppdwBkPlyvgMRAorRAJsFmwUCAs43aCTBFOomAQ0RoZxTowCfR7ls
PXsZ2ZXa7r0vUMsjsgceKt8=
=3Mxg
-----END PGP SIGNATURE-----