Bug#873338: [PATCH] build: backup existing binaries before installing

David Michael fedora.dm0 at gmail.com
Sat Aug 26 18:28:40 UTC 2017


Package: net-tools
Version: 1.60
Tags: patch

A parallel "make install" invocation can sometimes install programs
first, then backup those programs as *.old files.  This randomly
caused duplicate programs to be installed.

This change will only run the backup prior to installing, also
creating backups for updates.

Signed-off-by: David Michael <david.michael at coreos.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index bf67bc6..b14cadf 100644
--- a/Makefile
+++ b/Makefile
@@ -109,7 +109,7 @@ all:		config.h version.h subdirs $(PROGS)
 
 config: 	cleanconfig config.h
 
-install:	all savebin installbin installdata
+install:	all installbin installdata
 
 update: 	all installbin installdata
 
@@ -205,7 +205,7 @@ ipmaddr:	$(NET_LIB) ipmaddr.o
 mii-tool:	$(NET_LIB) mii-tool.o
 		$(CC) $(CFLAGS) $(LDFLAGS) -o $@ mii-tool.o $(NLIB) $(LDLIBS)
 
-installbin:
+installbin: savebin
 	@echo
 	@echo "######################################################"
 	@echo "Notice: ifconfig and route are now installed into /bin"
-- 
2.13.5



More information about the Pkg-net-tools-maintainers mailing list