Bug#387002: [pkg-ntp-maintainers] Bug#387002: ntp/ntpdate: Inaccurate LSB-header in init.d scripts

[Kurt Roeckx]

On Mon, Sep 11, 2006 at 05:54:48PM +0200, Petter Reinholdtsen wrote:
> 
> Package: ntp
> Version: 1:4.2.2+dfsg.2-1
> Tags:    patch
> 
> The LSB header for ntp is inaccurate and slightly incorrect.  It
> currently look like this:
> 
>   ### BEGIN INIT INFO
>   # Provides:        $time
>   # Required-Start:  $network
>   # Required-Stop:   $network
>   # Should-Start:    ntpdate
>   # Should-Stop:     ntpdate
>   # Default-Start:   S 1 2 3 4 5
>   # Default-Stop:    0 6
>   ### END INIT INFO
> 
> It should not start in the S runlevel, should stop in runlevel 1, and
> should not provide a facility name $time, but instead provide 'ntp'.
> I discovered this while testing a dependency based boot system.  It
> should probably also start after syslog and all file systems are
> mounted.  Please change it to look like this:

This is both in the LSB:
http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/facilname.html
and the debian wiki: http://wiki.debian.org/LSBInitScripts

   $time

   the system time has been set, for example by using a network-based
   time program such as ntp or rdate, or via the hardware Real Time
   Clock.

Although, I'm not really sure that ntpd should provide
this if it doesn't doesn't set the clock when the script
finishes.  But I currently can't see an argument for
ntpdate not providing it.  Is something else providing
this?

I'm also not sure if network is still needed during stop.
But the rest looks good.


Kurt