[pkg-ntp-maintainers] Bug#749761: ntp: /etc/cron.daily/ntp -- take account of multiple spaces or tabs for statsdir in /etc/ntp.conf

[J G Miller]

Package: ntp
Version: 1:4.2.6.p5+dfsg-2
Severity: normal
Tags: patch


The configuration file /etc/ntp.conf contains a line specifying the
statsdir path.  There may be multiple spaces and/or tabs between the statsdir
specifier and the actual specified path value.

The daily cron job /etc/cron.daily cleans up statsdir but in determining
the path assumes there is but a single space between statsdir and the path.

If this is not the case, the statsdir continues to fill up with lots
of files.

The following patch replaces the specifier for a single space` ' with
the GNU sed `\s' to denote white space (space or tab) and allows for
the possibility of one or more  space or tabs between statsdir and the
specified path.

------------------------<start of patch>-----------------------------------
--- /etc/cron.daily/ntp 2013-10-09 20:57:15.000000000 +0200
+++ /etc/cron.daily/ntp.OLD     2013-10-09 20:57:15.000000000 +0200
@@ -6,7 +6,7 @@
 # is delete old ones, and compress the ones we're keeping so disk
 # usage is controlled.

-statsdir=$(cat /etc/ntp.conf | grep -v '^#' | sed -n 's/statsdir\s\s*\([^ ][^ ]*\)/\1/p')
+statsdir=$(cat /etc/ntp.conf | grep -v '^#' | sed -n 's/statsdir \([^ ][^ ]*\)/\1/p')

 if [ -n "$statsdir" ] && [ -d "$statsdir" ]; then
        # only keep a week's depth of these
-------------------------<end of patch>------------------------------------

-- System Information:
Debian Release: 7.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: armel (armv5tel)

Kernel: Linux 3.14-1-kirkwood
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash

Versions of packages ntp depends on:
ii  adduser      3.113+nmu3
ii  dpkg         1.16.14
ii  libc6        2.13-38+deb7u1
ii  libcap2      1:2.22-1.2
ii  libedit2     2.11-20080614-5
ii  libgcc1      1:4.7.2-5
ii  libopts25    1:5.12-0.1
ii  libssl1.0.0  1.0.1e-2+deb7u9
ii  lsb-base     4.1+Debian8+deb7u1
ii  netbase      5.0

Versions of packages ntp recommends:
ii  perl  5.14.2-21+deb7u1

Versions of packages ntp suggests:
pn  ntp-doc  <none>

-- Configuration Files:
/etc/cron.daily/ntp changed [not included]
/etc/default/ntp changed [not included]
/etc/ntp.conf changed [not included]

-- no debconf information