[pkg-ntp-maintainers] Bug#851803: ntp: FTBFS (mv: cannot stat 'debian/tmp/usr/bin/ntpdate': No such file or directory)

[Santiago Vila]

Package: src:ntp
Version: 1:4.2.8p9+dfsg-2
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]

Installing stand-alone HTML documentation
make[4]: Leaving directory '/<<BUILDDIR>>/ntp-4.2.8p9+dfsg'
make[3]: Leaving directory '/<<BUILDDIR>>/ntp-4.2.8p9+dfsg'
make[2]: Leaving directory '/<<BUILDDIR>>/ntp-4.2.8p9+dfsg'
make[1]: Leaving directory '/<<BUILDDIR>>/ntp-4.2.8p9+dfsg'
# move the administrator programs from /usr/bin to /usr/sbin
for file in ntpdate ntp-wait ntpd ntptime ntp-keygen; do \
	mv debian/tmp/usr/bin/$file debian/tmp/usr/sbin/$file || exit; \
done
mv: cannot stat 'debian/tmp/usr/bin/ntpdate': No such file or directory
debian/rules:50: recipe for target 'install' failed
make: *** [install] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

The same failure happens in the reproducible builds autobuilders:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ntp.html

so I guess this should be easy to reproduce on a current stretch chroot.

Apparently ntpdate is already installed into usr/sbin and that's
why it does not exist in usr/bin anymore.

If that's the case, the trivial but untested patch below
would probably fix the problem (unless more binaries
are also in usr/sbin).

Because the same package version of ntp used to build in the past,
this is surely caused by a build-dependency that changed
behaviour.

So you might want to contact the maintainer of such build-dependency
that broke this and get a promise that the behaviour will not
change again between now and the release of stretch.

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -55,7 +55,7 @@ install: build-stamp
 	$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
 
 	# move the administrator programs from /usr/bin to /usr/sbin
-	for file in ntpdate ntp-wait ntpd ntptime ntp-keygen; do \
+	for file in ntp-wait ntpd ntptime ntp-keygen; do \
 		mv debian/tmp/usr/bin/$$file debian/tmp/usr/sbin/$$file || exit; \
 	done