[Pkg-nx-group] several small issues about nxcomp packaging

[Stefan Huehner]

Hi,

testing out the nxcomp-packaing from svn i notives several small issues:

- lintian bails out with an error because the version number ends with
  -0 perhaps an suffix '.0' corrects this error. I've modified the
  changelog accordingly. As .0 is not larger than the existing -0 i had
  to force the change. But as the package isn't released yet this
  shouldn't be a problem.
- When compiling i noticed several compiler-warnings about
  -Wstrict-protoypes and -Wmissings-prototypes not being legal C++
  command line options. So in create a new dpatch which moves these 2
  extra warnings from cxxflags to cflags.
- I havent't touched the other two illegal c++ commandline options
  -Wmissings-declarations and -Wnested-extern as there are conditionally
  added by configure and the configure.in macros seem a bit weird to me
  in checking gcc 3.3* as version string...?
- There seem to be a lot inclusions of deprecated headers. One could
  silence these by adding -Wno-deprecated as an additional parameter but
  creating an patch for correction the includes would probably be better
  (have to check if upstream 1.5er tree has the same problems).

Patch for the addressed issues is attached. Please comment.

Regards,
Stefan

-------------- next part --------------
Index: debian/patches/00list
===================================================================
--- debian/patches/00list	(revision 16)
+++ debian/patches/00list	(working copy)
@@ -1,2 +1,3 @@
 gcc4-classdef
 build_with_fpic
+sanitize_cxxflags
Index: debian/changelog
===================================================================
--- debian/changelog	(revision 16)
+++ debian/changelog	(working copy)
@@ -1,5 +1,12 @@
+nxcomp (1.4.0.2-31.0) UNRELEASED; urgency=low
+
+  * adjust verision number to fix lintian error
+
+ -- Stefan Huehner <stefan at huehner.org>  Sat, 23 Jul 2005 19:36:39 +0200
+
 nxcomp (1.4.0.2-31-0) UNRELEASED; urgency=low
 
+  [ Stefan Lippers-Hollmann ]
   Changes by Tollef Fog Heen:
     - Initial upload to Debian
     - Split package into sensible source packages
@@ -11,8 +18,13 @@
     - switch to unpacked sources due to build issues.
     - bump standards version to 3.6.2
 
- -- Stefan Lippers-Hollmann <s.l-h at gmx.de>  Wed, 20 Jul 2005 12:16:08 +0200
+  [ Stefan Huehner ]
+  * create new patch to address that
+    - -Wmissing-declarations and -Wstrict-prototypes are
+      gcc flags and not g++ flags
 
+ -- Stefan Huehner <stefan at huehner.org>  Sat, 23 Jul 2005 19:11:25 +0200
+
 nx (1.4.0.2-0alpha6) experimental; urgency=low
 
   * add automake1.4 to the build dependencies. 
--- /dev/null	2005-03-29 14:09:30.000000000 +0200
+++ debian/patches/sanitize_cxxflags.dpatch	2005-07-23 19:10:45.000000000 +0200
@@ -0,0 +1,26 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## sanitize-cxxflags.dpatch by  <Stefan Huehner <stefan at huehner.org>>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: -Wstrict-prototypes and -Wmissing declarations are gcc flags not g++ flags.
+
+ at DPATCH@
+diff -urNad --exclude=CVS --exclude=.svn ./Makefile.in /tmp/dpep-work.22H3PC/trunk/Makefile.in
+--- ./Makefile.in	2005-07-23 19:09:32.000000000 +0200
++++ /tmp/dpep-work.22H3PC/trunk/Makefile.in	2005-07-23 19:09:59.000000000 +0200
+@@ -12,13 +12,13 @@
+ 
+ CXX         = @CXX@
+ CXXFLAGS    = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
+-              -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes \
++              -Wall -Wpointer-arith \
+ 		-fPIC
+ CXXINCLUDES =
+ CXXDEFINES  =
+ 
+ CC          = @CC@
+-CCFLAGS     = $(CXXFLAGS)
++CCFLAGS     = $(CXXFLAGS) -Wstrict-prototypes -Wmissing-prototypes
+ CCINCLUDES  =
+ CCDEFINES   =
+