[Pkg-ocaml-maint-commits] r1324 - trunk/packages/mldonkey/trunk/debian

Sylvain LE GALL gildor-guest@costa.debian.org
Wed, 27 Apr 2005 22:39:34 +0000


Author: gildor-guest
Date: 2005-04-27 22:39:34 +0000 (Wed, 27 Apr 2005)
New Revision: 1324

Modified:
   trunk/packages/mldonkey/trunk/debian/README.Debian
   trunk/packages/mldonkey/trunk/debian/TODO
   trunk/packages/mldonkey/trunk/debian/changelog
   trunk/packages/mldonkey/trunk/debian/control
   trunk/packages/mldonkey/trunk/debian/mldonkey-server.init
Log:
Work in progress on mldonkey -- SLG


Modified: trunk/packages/mldonkey/trunk/debian/README.Debian
===================================================================
--- trunk/packages/mldonkey/trunk/debian/README.Debian	2005-04-26 23:24:51 UTC (rev 1323)
+++ trunk/packages/mldonkey/trunk/debian/README.Debian	2005-04-27 22:39:34 UTC (rev 1324)
@@ -162,6 +162,14 @@
  
  -- Sylvain LE GALL <sylvain.le-gall@polytechnique.org>  Sun, 01 Feb 2004 21:56:00 +0200
 
+If you try to use the init script of mldonkey, you should encounter problem with the option
+used for the nicelevel of start-stop-daemon. On woody system, it seems that you could only
+have a niceness of 0 set by this way.
+
+Use a niceness of 0 when using Woody start-stop-daemon.
+
+ -- Sylvain Le Gall <sylvain.le-gall@polytechnique.org>  Wed, 27 Apr 2005 23:35:36 +0200
+
 ----------------------
 * Note for upgrading *
 ----------------------
@@ -206,3 +214,23 @@
 
  -- Sylvain Le Gall <sylvain.le-gall@polytechnique.org>  Mon, 24 Aug 2004 23:23:00 +0200
 
+----------------------
+* Force startup      *
+----------------------
+
+Since the beginning of the package, a choice has been made to allow user to choose to start
+MLDonkey or not at startup. This decision was made because mldonkey is not an essential service
+and can be a really heavy time/network/processor consumer.
+
+However, it should be interesting to be able to start mldonkey, as configured during the install
+after the boot ( ie when you know that you can start it ). But the fact that you have configured
+the script not to start at startup, prevents user to do that.
+
+Some users proposed to link/not to link startup script from /etc/rcX.d/SXXmldonkey-server to 
+/etc/init.d/mldonkey-server. This way is a violation of the debian policy ( at least i think so ).
+
+I decide to let user be able to start the script using : "/etc/init.d/mldonkey-server force-start". 
+This way, we are policy compliant and we let user start mldonkey-server, when needed.
+
+ -- Sylvain Le Gall <sylvain.le-gall@polytechnique.org>  Wed, 27 Apr 2005 23:35:36 +0200
+

Modified: trunk/packages/mldonkey/trunk/debian/TODO
===================================================================
--- trunk/packages/mldonkey/trunk/debian/TODO	2005-04-26 23:24:51 UTC (rev 1323)
+++ trunk/packages/mldonkey/trunk/debian/TODO	2005-04-27 22:39:34 UTC (rev 1324)
@@ -1,7 +1,51 @@
-Version 2.5
 
 * Build packages for :
  - kde_applet
  - gnome_applet
  - mozilla plugin
 
+* Correct bugs : 
+  Grave functionality bugs - outstanding
+  #279030: mldonkey-server: debconf configuration is entirely ignored
+  #299722: mldonkey-server does not start because of /var/run/mldonkey permissions
+  #300560: mldonkey-server: downloads.ini writable by group users, world-readable
+
+  Important bugs - outstanding
+  #244406: mldonkey-server: A new problem of mldonkey_server
+  #247205: mldonkey-server: it eats all the CPU and memory and malfunction
+  #268690: 2.5.28 fails to properly connect to mlnet
+  #270476: mldonkey-server: html-gui asks for username and password after upgrade
+  #277353: mldonkey-server: dpkg --purge does not work
+
+  Normal bugs - outstanding
+  #204266: Chrooted mldonkey-server seems to be broken
+  #231553: mldonkey-server: cache.shareaza.com points to localhost
+  #254000: logs to syslog instead of using own logfiles in /var/log/mldonkey/
+  #255245: mldonkey-server: does run with permissions of groups that the mldonkey user is added to
+  #263094: mldonkey: Extra files to distribute
+  #269947: mldonkey-server saved chinese filename
+  #270371: mldonkey-gui: graphical availablility isn't displayed
+  #271725: mldonkey-server.templates and templates.pot differ (are out of sync)
+  #272250: mldonkey-server: Downloads/Uploads are not visible through html interface
+  #272405: mldonkey-gui: can't change priority
+  #280551: mldonkey-server: does not start when stale pidfile exists
+  #281086: Licence des pages man de mldonkey
+  #283930: mldonkey-server package bug. Daemon not able to start due to tmp file left after reboot.
+  #285202: disconnect mldonkey-server if non-iso8859-1 characters typed in search section
+  #291451: mldonkey-server: Server not starting after reboot
+  #293155: mldonkey-server: init.d problems
+  #296722: mldonkey-server: cannot add groups to mldonkey user
+  #301093: creates empty file duplicates in incoming after originals removed
+
+  Minor bugs - outstanding
+  #270283: many typos in mldonkey-server.templates (aka debconf template)
+  #285231: Wrong comment in downloads.ini
+  #293016: mldonkey-server: Logical '-not' in searches not supported
+  #300547: mldonkey-server: package un-install forgets to stop server
+
+  Wishlist items - outstanding
+  #271462: Updated Czech translation of mldonkey debconf messages
+  #271727: mldonkey-server: [l10n:de] German debconf translation
+  #272837: mldonkey-server: show emule comments in file property
+  #274460: consider packaging KMLDonkey
+  #295854: mldonkey-server: Remove lost pid file

Modified: trunk/packages/mldonkey/trunk/debian/changelog
===================================================================
--- trunk/packages/mldonkey/trunk/debian/changelog	2005-04-26 23:24:51 UTC (rev 1323)
+++ trunk/packages/mldonkey/trunk/debian/changelog	2005-04-27 22:39:34 UTC (rev 1324)
@@ -5,7 +5,19 @@
   * Transition to ocaml 3.08.3 : changes depends in control
   * Remove patch 18_utf8_encoding since it is applied upstream
   * Remove patch 19_mlgui_align since it is applied upstream
+  * Depends on docbook-xsl 1.64.1 and docbook-xml 4.2-12 ( Closes: #276750, #276751 )
+  * Changes MDLONKEY_DIR to MLDONKEY_DIR at line 34 in the init.d file ( Closes: #296573, #273156 )
+  * Create a command "force-start" to force the start of mldonkey, even if it is configured not to
+    start at startup. All other command don't take into account the value of the variable ( so you
+    can stop or restart a running server, without knowing how it was started ) ( Closes: #225724 )
+  * The problem the option "--purge" should have been solved in UCF itself : i cannot reproduce the bug,
+    UCF definitively stats the existence of such an option in "man ucf" and "ucf --help". ( Closes: #277353 )
+  * Depends on dpkg 1.10.27, those forcing to have a defined behavior for the option --nicelevel. Put a not 
+    for backporters in README.Debian ( Closes: #277772 )
+  * Issue concerning /etc/menu-methods/kdebase seem to have been discussed in bug #247407 and solved
+    ( Closes: #276649 )
 
+
  -- Sylvain Le Gall <sylvain.le-gall@polytechnique.org>  Tue, 26 Apr 2005 22:55:10 +0200
 
 mldonkey (2.5.28-2) unstable; urgency=medium

Modified: trunk/packages/mldonkey/trunk/debian/control
===================================================================
--- trunk/packages/mldonkey/trunk/debian/control	2005-04-26 23:24:51 UTC (rev 1323)
+++ trunk/packages/mldonkey/trunk/debian/control	2005-04-27 22:39:34 UTC (rev 1324)
@@ -2,12 +2,12 @@
 Section: net
 Priority: optional
 Maintainer: Sylvain Le Gall <sylvain.le-gall@polytechnique.org> 
-Build-Depends: ocaml-nox-3.08.3, debhelper (>= 4.1.16), po-debconf, xsltproc, zlib1g-dev, docbook-xsl, docbook-xml, chrpath, m4, dpatch (>= 1.11), debconf (>= 0.2.26), liblablgtk2-ocaml-dev
+Build-Depends: ocaml-nox-3.08.3, debhelper (>= 4.1.16), po-debconf, xsltproc, zlib1g-dev, docbook-xsl (>= 1.64.1), docbook-xml (>= 4.2-12), chrpath, m4, dpatch (>= 1.11), debconf (>= 0.2.26), liblablgtk2-ocaml-dev
 Standards-Version: 3.6.1.0
 
 Package: mldonkey-server
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, ${interpreter:Depends}, adduser, mime-support, debconf (>= 0.2.26), ucf
+Depends: ${shlibs:Depends}, ${misc:Depends}, ${interpreter:Depends}, adduser, mime-support, debconf (>= 0.2.26), ucf (>= 1.17), dpkg (>= 1.10.27)
 Description: Door to the 'donkey' network
  MLDonkey is a door to the 'donkey' network, a decentralized network used to
  exchange big files on the Internet. It is written in a wonderful language,

Modified: trunk/packages/mldonkey/trunk/debian/mldonkey-server.init
===================================================================
--- trunk/packages/mldonkey/trunk/debian/mldonkey-server.init	2005-04-26 23:24:51 UTC (rev 1323)
+++ trunk/packages/mldonkey/trunk/debian/mldonkey-server.init	2005-04-27 22:39:34 UTC (rev 1324)
@@ -26,12 +26,13 @@
 
 . $CONFIG
 
-if [ "$LAUNCH_AT_STARTUP" != "true" ]; then
+if [ "x$LAUNCH_AT_STARTUP" != "xtrue" ] && [ "x$1" = "xstart" ]; then
+  echo "$DESC is configured not start ( see file /etc/default/mldonkey-server )"
   exit 0
 fi
 
-if [ ! -d $MLDONKEY_DIR ]; then
-  if [ -z "$MDLONKEY_DIR" ]; then
+if [ -z "$MLDONKEY_DIR" ] || [ ! -d $MLDONKEY_DIR ]; then
+  if [ -z "$MLDONKEY_DIR" ]; then
     MLDONKEY_DIR="(unset)"
   fi
   echo "$MLDONKEY_DIR is not a valid directory"
@@ -62,6 +63,10 @@
 
 case "$1" in
   start)
+    $0 force-start
+    ;;
+    
+  force-start)
     echo -n "Starting $DESC: $NAME"
     
     # export MLDONKEY_CHROOT=$MLDONKEY_DIR
@@ -99,7 +104,7 @@
   ;;
   
   *)
-    echo "Usage: $0 {start|stop|restart|force-reload}" >&2
+    echo "Usage: $0 {start|stop|restart|force-reload|force-start}" >&2
     exit 1
   ;;
 esac